Skip to content

Commit 7429c39

Browse files
committed
remove unnecessary parameters from the hub wait_for methods
1 parent f088c1a commit 7429c39

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

pybricksdev/connections/pybricks.py

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -741,9 +741,7 @@ def handle_power_button_press(status: StatusFlag):
741741
)
742742
return awaitable_task.result()
743743

744-
async def _wait_for_power_button_release(
745-
self, program_start_timeout=1, raise_error_on_timeout=False
746-
):
744+
async def _wait_for_power_button_release(self):
747745
power_button_pressed: asyncio.Queue[bool] = asyncio.Queue()
748746

749747
with self.status_observable.pipe(
@@ -761,11 +759,9 @@ async def _wait_for_power_button_release(
761759
try:
762760
await asyncio.wait_for(
763761
self.race_disconnect(power_button_pressed.get()),
764-
program_start_timeout,
762+
1,
765763
)
766764
except asyncio.TimeoutError:
767-
if raise_error_on_timeout:
768-
raise
769765
# If the button never shows as pressed,
770766
# assume that we just missed the status flag
771767
logger.debug(
@@ -781,9 +777,7 @@ async def _wait_for_power_button_release(
781777
# maybe catch mistake if the code is changed
782778
assert not is_pressed
783779

784-
async def _wait_for_user_program_stop(
785-
self, program_start_timeout=1, raise_error_on_timeout=False
786-
):
780+
async def _wait_for_user_program_stop(self):
787781
user_program_running: asyncio.Queue[bool] = asyncio.Queue()
788782

789783
with self.status_observable.pipe(
@@ -801,11 +795,9 @@ async def _wait_for_user_program_stop(
801795
try:
802796
await asyncio.wait_for(
803797
self.race_disconnect(user_program_running.get()),
804-
program_start_timeout,
798+
1,
805799
)
806800
except asyncio.TimeoutError:
807-
if raise_error_on_timeout:
808-
raise
809801
# if it doesn't start, assume it was a very short lived
810802
# program and we just missed the status message
811803
logger.debug(

0 commit comments

Comments
 (0)