remove csr abc (#11994)

Author: reaperhulk

src/cryptography/hazmat/bindings/_rust/x509.pyi

@@ -148,7 +148,34 @@ class CertificateRevocationList:
         self, public_key: CertificateIssuerPublicKeyTypes
     ) -> bool: ...
 
-class CertificateSigningRequest: ...
+class CertificateSigningRequest:
+    def __eq__(self, other: object) -> bool: ...
+    def __hash__(self) -> int: ...
+    def public_key(self) -> CertificatePublicKeyTypes: ...
+    @property
+    def subject(self) -> x509.Name: ...
+    @property
+    def signature_hash_algorithm(
+        self,
+    ) -> hashes.HashAlgorithm | None: ...
+    @property
+    def signature_algorithm_oid(self) -> x509.ObjectIdentifier: ...
+    @property
+    def signature_algorithm_parameters(
+        self,
+    ) -> None | PSS | PKCS1v15 | ECDSA: ...
+    @property
+    def extensions(self) -> x509.Extensions: ...
+    @property
+    def attributes(self) -> x509.Attributes: ...
+    def public_bytes(self, encoding: serialization.Encoding) -> bytes: ...
+    @property
+    def signature(self) -> bytes: ...
+    @property
+    def tbs_certrequest_bytes(self) -> bytes: ...
+    @property
+    def is_signature_valid(self) -> bool: ...
+    def get_attribute_for_oid(self, oid: x509.ObjectIdentifier) -> bytes: ...
 
 class PolicyBuilder:
     def time(self, new_time: datetime.datetime) -> PolicyBuilder: ...

src/cryptography/x509/base.py

@@ -12,7 +12,7 @@
 
 from cryptography import utils
 from cryptography.hazmat.bindings._rust import x509 as rust_x509
-from cryptography.hazmat.primitives import hashes, serialization
+from cryptography.hazmat.primitives import hashes
 from cryptography.hazmat.primitives.asymmetric import (
     dsa,
     ec,
@@ -232,111 +232,7 @@ def extensions(self) -> Extensions:
 
 
 CertificateRevocationList = rust_x509.CertificateRevocationList
-
-
-class CertificateSigningRequest(metaclass=abc.ABCMeta):
-    @abc.abstractmethod
-    def __eq__(self, other: object) -> bool:
-        """
-        Checks equality.
-        """
-
-    @abc.abstractmethod
-    def __hash__(self) -> int:
-        """
-        Computes a hash.
-        """
-
-    @abc.abstractmethod
-    def public_key(self) -> CertificatePublicKeyTypes:
-        """
-        Returns the public key
-        """
-
-    @property
-    @abc.abstractmethod
-    def subject(self) -> Name:
-        """
-        Returns the subject name object.
-        """
-
-    @property
-    @abc.abstractmethod
-    def signature_hash_algorithm(
-        self,
-    ) -> hashes.HashAlgorithm | None:
-        """
-        Returns a HashAlgorithm corresponding to the type of the digest signed
-        in the certificate.
-        """
-
-    @property
-    @abc.abstractmethod
-    def signature_algorithm_oid(self) -> ObjectIdentifier:
-        """
-        Returns the ObjectIdentifier of the signature algorithm.
-        """
-
-    @property
-    @abc.abstractmethod
-    def signature_algorithm_parameters(
-        self,
-    ) -> None | padding.PSS | padding.PKCS1v15 | ec.ECDSA:
-        """
-        Returns the signature algorithm parameters.
-        """
-
-    @property
-    @abc.abstractmethod
-    def extensions(self) -> Extensions:
-        """
-        Returns the extensions in the signing request.
-        """
-
-    @property
-    @abc.abstractmethod
-    def attributes(self) -> Attributes:
-        """
-        Returns an Attributes object.
-        """
-
-    @abc.abstractmethod
-    def public_bytes(self, encoding: serialization.Encoding) -> bytes:
-        """
-        Encodes the request to PEM or DER format.
-        """
-
-    @property
-    @abc.abstractmethod
-    def signature(self) -> bytes:
-        """
-        Returns the signature bytes.
-        """
-
-    @property
-    @abc.abstractmethod
-    def tbs_certrequest_bytes(self) -> bytes:
-        """
-        Returns the PKCS#10 CertificationRequestInfo bytes as defined in RFC
-        2986.
-        """
-
-    @property
-    @abc.abstractmethod
-    def is_signature_valid(self) -> bool:
-        """
-        Verifies signature of signing request.
-        """
-
-    @abc.abstractmethod
-    def get_attribute_for_oid(self, oid: ObjectIdentifier) -> bytes:
-        """
-        Get the attribute value for a given OID.
-        """
-
-
-# Runtime isinstance checks need this since the rust class is not a subclass.
-CertificateSigningRequest.register(rust_x509.CertificateSigningRequest)
+CertificateSigningRequest = rust_x509.CertificateSigningRequest
 
 
 load_pem_x509_certificate = rust_x509.load_pem_x509_certificate