fixes #13812 -- have Name.__repr__ put things in RFC4514 order (#13817)

Author: alex

docs/x509/reference.rst

@@ -764,7 +764,7 @@ X.509 CRL (Certificate Revocation List) Object
         .. doctest::
 
             >>> crl.issuer
-            <Name(C=US,CN=cryptography.io)>
+            <Name(CN=cryptography.io,C=US)>
 
     .. attribute:: next_update
 

src/cryptography/x509/name.py

@@ -366,8 +366,7 @@ def __len__(self) -> int:
         return sum(len(rdn) for rdn in self._attributes)
 
     def __repr__(self) -> str:
-        rdns = ",".join(attr.rfc4514_string() for attr in self._attributes)
-        return f"<Name({rdns})>"
+        return f"<Name({self.rfc4514_string()})>"
 
 
 class _RFC4514NameParser:

tests/x509/test_x509.py

@@ -1694,15 +1694,15 @@ def test_public_bytes_match(
         serialized = cert.public_bytes(encoding)
         assert serialized == cert_bytes
 
-    def test_certificate_repr(self, backend):
+    def test_certificate_repr(self):
         cert = _load_cert(
             os.path.join("x509", "cryptography.io.pem"),
             x509.load_pem_x509_certificate,
         )
         assert repr(cert) == (
-            "<Certificate(subject=<Name(OU=GT48742965,OU=See www.rapidssl.com"
-            "/resources/cps (c)14,OU=Domain Control Validated - RapidSSL(R),"
-            "CN=www.cryptography.io)>, ...)>"
+            "<Certificate(subject=<Name(CN=www.cryptography.io,OU=Domain "
+            "Control Validated - RapidSSL(R),OU=See "
+            "www.rapidssl.com/resources/cps (c)14,OU=GT48742965)>, ...)>"
         )
 
     def test_parse_tls_feature_extension(self, backend):
@@ -5790,7 +5790,7 @@ def test_load_ecdsa_cert_null_alg_params(self, backend):
             assert isinstance(cert.signature_hash_algorithm, hashes.SHA256)
             assert isinstance(cert.public_key(), ec.EllipticCurvePublicKey)
 
-    def test_load_bitstring_dn(self, backend):
+    def test_load_bitstring_dn(self):
         cert = _load_cert(
             os.path.join("x509", "scottishpower-bitstring-dn.pem"),
             x509.load_pem_x509_certificate,
@@ -5809,7 +5809,7 @@ def test_load_bitstring_dn(self, backend):
             ]
         )
         assert repr(cert.subject) == (
-            "<Name(CN=ScottishPower,OU=02,2.5.4.45=#0070b3d51f305f0001)>"
+            "<Name(2.5.4.45=#0070b3d51f305f0001,OU=02,CN=ScottishPower)>"
         )
 
     def test_load_name_attribute_long_form_asn1_tag(self, backend):
@@ -6409,12 +6409,12 @@ def test_rdns(self):
             (
                 "cryptography.io",
                 "PyCA",
-                "<Name(CN=cryptography.io,O=PyCA)>",
+                "<Name(O=PyCA,CN=cryptography.io)>",
             ),
             (
                 "Certificación",
                 "Certificación",
-                "<Name(CN=Certificación,O=Certificación)>",
+                "<Name(O=Certificación,CN=Certificación)>",
             ),
         ],
     )