support explicit curves mapping to named curves (for some curves) #12916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're going to need a 1.83 MSRV due to needing Option::unwrap in const context or else we'll have to change the approach to avoid use const values. |
We now support loading EC keys with explicit encodings of named curves. This requires that the explicit curve encoding match exactly (but allows the omission of the seed parameter to maintain compatibility with the -no_seed OpenSSL flag). This is only supported for secp256r1, secp384r1, secp521r1, and secp256k1 at this time. This is not arbitrary explicit curve support; we still have no plans to implement that. This PR also updates MSRV to 1.83 as we need that version for Option::unwrap() in const contexts.
MFM007
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support loading EC keys with explicit encodings of named curves. This requires that the explicit curve encoding match exactly (but allows the omission of the seed parameter to maintain compatibility with the -no_seed OpenSSL flag). This is only supported for secp256r1, secp384r1, secp521r1, and secp256k1 at this time.
This is not arbitrary explicit curve support; we still have no plans to implement that.
This PR also updates MSRV to 1.83 as we need that version for Option::unwrap() in const contexts and thus is blocked until we feel comfortable with that bump (As of late May 2025 75% of our sdist downloads have 1.83+)