Skip to content

Commit b6e8c3c

Browse files
authored
Don't assign to names that aren't used (#1356)
Identified by `ruff check --preview`
1 parent 8006f48 commit b6e8c3c

File tree

1 file changed

+13
-17
lines changed

1 file changed

+13
-17
lines changed

tests/test_ssl.py

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1525,8 +1525,7 @@ def _use_certificate_chain_file_test(self, certdir):
15251525
it with a client which trusts cacert and requires verification to
15261526
succeed.
15271527
"""
1528-
chain = _create_certificate_chain()
1529-
[(cakey, cacert), (ikey, icert), (skey, scert)] = chain
1528+
[(_, cacert), (_, icert), (skey, scert)] = _create_certificate_chain()
15301529

15311530
makedirs(certdir)
15321531

@@ -2470,7 +2469,7 @@ def test_shutdown_closed(self):
24702469
If the underlying socket is closed, `Connection.shutdown` propagates
24712470
the write error from the low level write call.
24722471
"""
2473-
server, client = loopback()
2472+
server, _ = loopback()
24742473
server.sock_shutdown(2)
24752474
with pytest.raises(SysCallError) as exc:
24762475
server.shutdown()
@@ -2554,8 +2553,7 @@ def test_get_certificate(self):
25542553
"""
25552554
`Connection.get_certificate` returns the local certificate.
25562555
"""
2557-
chain = _create_certificate_chain()
2558-
[(cakey, cacert), (ikey, icert), (skey, scert)] = chain
2556+
[_, _, (_, scert)] = _create_certificate_chain()
25592557

25602558
context = Context(SSLv23_METHOD)
25612559
context.use_certificate(scert)
@@ -2587,8 +2585,7 @@ def test_get_peer_cert_chain(self):
25872585
`Connection.get_peer_cert_chain` returns a list of certificates
25882586
which the connected server returned for the certification verification.
25892587
"""
2590-
chain = _create_certificate_chain()
2591-
[(cakey, cacert), (ikey, icert), (skey, scert)] = chain
2588+
[(_, cacert), (_, icert), (skey, scert)] = _create_certificate_chain()
25922589

25932590
serverContext = Context(SSLv23_METHOD)
25942591
serverContext.use_privatekey(skey)
@@ -2647,8 +2644,7 @@ def test_get_verified_chain(self):
26472644
`Connection.get_verified_chain` returns a list of certificates
26482645
which the connected server returned for the certification verification.
26492646
"""
2650-
chain = _create_certificate_chain()
2651-
[(cakey, cacert), (ikey, icert), (skey, scert)] = chain
2647+
[(_, cacert), (_, icert), (skey, scert)] = _create_certificate_chain()
26522648

26532649
serverContext = Context(SSLv23_METHOD)
26542650
serverContext.use_privatekey(skey)
@@ -2759,7 +2755,7 @@ def test_server_get_session(self):
27592755
On the server side of a connection, `Connection.get_session` returns a
27602756
`Session` instance representing the SSL session for that connection.
27612757
"""
2762-
server, client = loopback()
2758+
server, _ = loopback()
27632759
session = server.get_session()
27642760
assert isinstance(session, Session)
27652761

@@ -2769,7 +2765,7 @@ def test_client_get_session(self):
27692765
returns a `Session` instance representing the SSL session for
27702766
that connection.
27712767
"""
2772-
server, client = loopback()
2768+
_, client = loopback()
27732769
session = client.get_session()
27742770
assert isinstance(session, Session)
27752771

@@ -2813,7 +2809,7 @@ def makeClient(socket):
28132809
client.set_session(originalSession)
28142810
return client
28152811

2816-
resumedServer, resumedClient = loopback(
2812+
resumedServer, _ = loopback(
28172813
server_factory=makeServer, client_factory=makeClient
28182814
)
28192815

@@ -2851,7 +2847,7 @@ def makeOriginalClient(socket):
28512847
client.set_connect_state()
28522848
return client
28532849

2854-
originalServer, originalClient = loopback(
2850+
_, originalClient = loopback(
28552851
server_factory=makeServer, client_factory=makeOriginalClient
28562852
)
28572853
originalSession = originalClient.get_session()
@@ -2872,7 +2868,7 @@ def test_wantWriteError(self):
28722868
`OpenSSL.SSL.WantWriteError` if writing to the connection's BIO
28732869
fail indicating a should-write state.
28742870
"""
2875-
client_socket, server_socket = socket_pair()
2871+
client_socket, _ = socket_pair()
28762872
# Fill up the client's send buffer so Connection won't be able to write
28772873
# anything. Start by sending larger chunks (Windows Socket I/O is slow)
28782874
# and continue by writing a single byte at a time so we can be sure we
@@ -2926,7 +2922,7 @@ def test_get_finished(self):
29262922
from client, or server. Finished messages are send during
29272923
TLS handshake.
29282924
"""
2929-
server, client = loopback()
2925+
server, _ = loopback()
29302926

29312927
assert server.get_finished() is not None
29322928
assert len(server.get_finished()) > 0
@@ -2937,7 +2933,7 @@ def test_get_peer_finished(self):
29372933
message received from client, or server. Finished messages are send
29382934
during TLS handshake.
29392935
"""
2940-
server, client = loopback()
2936+
server, _ = loopback()
29412937

29422938
assert server.get_peer_finished() is not None
29432939
assert len(server.get_peer_finished()) > 0
@@ -3402,7 +3398,7 @@ def test_closed(self):
34023398
If the underlying socket is closed, `Connection.sendall` propagates the
34033399
write error from the low level write call.
34043400
"""
3405-
server, client = loopback()
3401+
server, _ = loopback()
34063402
server.sock_shutdown(2)
34073403
with pytest.raises(SysCallError) as err:
34083404
server.sendall(b"hello, world")

0 commit comments

Comments
 (0)