Bot improvements (pyccel#1949)

Change the key for the `check_runs` dict so that information about the
Python version is not lost. This allows results from multiple Python
versions to be considered together. This should let the coverage test
use results from multiple Python versions.

It is extremely difficult to test this kind of PR. Please review as well
as you, it will then have to be tested in the devel branch on pyccel#1906 and
minor fixes may need to be done quickly after the merge

Author: EmilyBourne

ci_tools/bot_tools/bot_funcs.py

@@ -291,10 +291,11 @@ def run_tests(self, tests, python_version = None, force_run = False):
             check_runs = {self.get_name_key(c["name"]): c for c in self._GAI.get_check_runs(self._ref)['check_runs']}
             already_triggered = [c["name"] for n,c in check_runs.items() if c['status'] in ('completed', 'in_progress') and \
                                                                             c['conclusion'] != 'cancelled' and \
-                                                                            n != 'coverage']
+                                                                            n != ('coverage', default_python_versions['coverage'])]
             already_triggered_names = [self.get_name_key(t) for t in already_triggered]
-            already_programmed = {c["name"]:c for c in check_runs.values() if c['status'] == 'queued'}
-            success_names = [n for n,c in check_runs.items() if c['status'] == 'completed' and c['conclusion'] == 'success']
+            already_programmed = {n:c for n,c in check_runs.items() if c['status'] == 'queued'}
+            success_names = [n if not isinstance(n, tuple) else n[0] for n,c in check_runs.items()
+                                if c['status'] == 'completed' and c['conclusion'] == 'success']
             print(already_triggered)
             states = []
 
@@ -313,11 +314,11 @@ def run_tests(self, tests, python_version = None, force_run = False):
 
             for t in tests:
                 pv = python_version or default_python_versions[t]
-                key = f"({t}, {pv})"
-                if any(key in a for a in already_triggered):
-                    states.append(check_runs[t]['conclusion'])
+                key = (t, pv)
+                if key in already_triggered_names:
+                    states.append(check_runs[key]['conclusion'])
                     continue
-                name = f"{test_names[t]} {key}"
+                name = f"{test_names[t]} ({t}, {pv})"
                 if not force_run and not self.is_test_required(commit_log, name, t, states):
                     continue
                 states.append('queued')
@@ -994,7 +995,7 @@ def get_name_key(self, name):
             The name which can be used as a key.
         """
         if '(' in name:
-            return name.split('(')[1].split(',')[0]
+            return name.split('(')[1].split(')')[0].split(', ')
         elif 'Codacy' in name:
             return 'Codacy'
         else:

ci_tools/bot_tools/github_api_interactions.py

@@ -394,7 +394,15 @@ def get_comments(self, pr_id):
             A dictionary containing the comments.
         """
         url = f"https://api.github.com/repos/{self._org}/{self._repo}/issues/{pr_id}/comments"
-        return self._post_request("GET", url).json()
+        results = []
+        page = 1
+        new_results = [None]
+        while len(new_results) != 0:
+            request = self._post_request("GET", url, params={'per_page': '100', 'page': str(page)})
+            new_results = request.json()
+            results.extend(new_results)
+            page += 1
+        return results
 
     def get_review_comments(self, pr_id):
         """