Skip to content

Commit f657701

Browse files
authored
Improve Windows install (pyccel#1817)
In the Windows installation, do not use the `sleep` command to wait for an executable to finish, as this leads to random crashes. Instead, use the proper Windows commands (taken from PR pyccel#1180) to wait for the execution.
1 parent b39fe9a commit f657701

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

.github/actions/windows_install/action.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,8 @@ runs:
5252
curl https://github.com/microsoft/Microsoft-MPI/releases/download/v10.1.1/msmpisdk.msi -o msmpisdk.msi
5353
#
5454
# Install MS MPI
55-
./msmpisetup.exe -unattend -verbose
56-
sleep 30
57-
msiexec /quiet /i msmpisdk.msi
58-
sleep 1
55+
Start-Process msmpisetup.exe -Wait -ArgumentList '-unattend -verbose'
56+
Start-Process msiexec -Wait -ArgumentList '/quiet /i msmpisdk.msi'
5957
echo "MS MPI runtime and SDK installed"
6058
shell: powershell
6159
- name: Setup MPI

0 commit comments

Comments
 (0)