[Issue-1961] Handle clippy::semicolon_if_nothing_returned (tensorzero#2814)

* [Issue-1961] Handle clippy::semicolon_if_nothing_returned

* Remove cfg of e2e test field

Author: michaldorsett

Cargo.toml

@@ -82,6 +82,7 @@ panic = "deny"
 print_stderr = "deny"
 print_stdout = "deny"
 redundant_closure_for_method_calls = "deny"
+semicolon-if-nothing-returned = "deny"
 todo = "deny"
 trivially_copy_pass_by_ref = "deny"
 unimplemented = "deny"

clients/rust/src/lib.rs

@@ -1185,7 +1185,7 @@ impl Client {
             ClientMode::HTTPGateway(client) => {
                 // Acquire the lock on the gateway version
                 let mut gateway_version = client.gateway_version.lock().await;
-                *gateway_version = Some(version)
+                *gateway_version = Some(version);
             }
             // Should never be called
             ClientMode::EmbeddedGateway { .. } => {}

evaluations/src/evaluators/llm_judge/mod.rs

@@ -297,7 +297,7 @@ fn prepare_messages_input(input: &ClientInput) -> Result<Vec<ClientInputMessage>
                     content: vec![ClientInputMessageContent::Text(TextKind::Text {
                         text: system_message,
                     })],
-                })
+                });
             }
             _ => {
                 bail!("System message is not a string or object");

evaluations/src/main.rs

@@ -27,7 +27,7 @@ async fn main() -> Result<()> {
     match &result {
         Ok(_) => info!(evaluation_run_id = %evaluation_run_id, "Evaluation completed successfully"),
         Err(e) => {
-            tracing::error!(evaluation_run_id = %evaluation_run_id, error = %e, "Evaluation failed")
+            tracing::error!(evaluation_run_id = %evaluation_run_id, error = %e, "Evaluation failed");
         }
     }
 

evaluations/src/stats.rs

@@ -54,7 +54,7 @@ impl EvaluationStats {
         }
         match evaluation_update {
             EvaluationUpdate::Success(evaluation_info) => {
-                self.evaluation_infos.push(evaluation_info)
+                self.evaluation_infos.push(evaluation_info);
             }
             EvaluationUpdate::Error(evaluation_error) => {
                 self.evaluation_errors.push(evaluation_error);

evaluations/tests/tests.rs

@@ -1734,7 +1734,7 @@ async fn run_evaluations_best_of_3() {
                 assert!(model_inference["system"]
                     .as_str()
                     .unwrap()
-                    .starts_with("You are an assistant tasked with re-ranking"))
+                    .starts_with("You are an assistant tasked with re-ranking"));
             }
         }
         assert_eq!(happy_count, 3);
@@ -1922,7 +1922,7 @@ async fn run_evaluations_mixture_of_3() {
                 assert!(model_inference["system"]
                     .as_str()
                     .unwrap()
-                    .starts_with("You have been provided with a set of responses from various"))
+                    .starts_with("You have been provided with a set of responses from various"));
             }
         }
         assert_eq!(happy_count, 3);

internal/tensorzero-derive/tests/deserialize.rs

@@ -33,7 +33,7 @@ fn test_good_deserialize() {
             },
             field2: true,
         }
-    )
+    );
 }
 
 #[test]

tensorzero-core/build.rs

@@ -8,5 +8,5 @@ fn main() {
     if std::env::var("TENSORZERO_SKIP_BUILD_INFO").is_ok() {
         println!("cargo:rerun-if-env-changed=TENSORZERO_SKIP_BUILD_INFO");
     }
-    built::write_built_file().expect("Failed to acquire build-time information")
+    built::write_built_file().expect("Failed to acquire build-time information");
 }

tensorzero-core/src/config_parser/mod.rs

@@ -237,7 +237,7 @@ impl ObjectStoreInfo {
                 }
                 if let Some(allow_http) = *allow_http {
                     if allow_http {
-                        tracing::warn!("`[object_storage.allow_http]` is set to `true` - this is insecure, and should only be used when running a local S3-compatible object store")
+                        tracing::warn!("`[object_storage.allow_http]` is set to `true` - this is insecure, and should only be used when running a local S3-compatible object store");
                     }
                     builder = builder.with_allow_http(allow_http);
                 }
@@ -454,7 +454,7 @@ impl Config {
 
     async fn load_from_toml(table: toml::Table, base_path: PathBuf) -> Result<Config, Error> {
         if table.is_empty() {
-            tracing::info!("Config file is empty, so only default functions will be available.")
+            tracing::info!("Config file is empty, so only default functions will be available.");
         }
         let uninitialized_config = UninitializedConfig::try_from(table)?;
 

tensorzero-core/src/config_parser/tests.rs

@@ -1521,7 +1521,7 @@ async fn test_empty_config() {
         .unwrap();
     assert!(logs_contain(
         "Config file is empty, so only default functions will be available."
-    ))
+    ));
 }
 
 #[tokio::test]