fix: "Create project" should prompt before overwriting existing files

Author: jakobrosenberg

src/commands/index.js

@@ -1,7 +1,7 @@
-const { mkdirSync, readFileSync, writeFileSync } = require("fs");
+const { mkdirSync, readFileSync, writeFileSync, readdirSync } = require("fs");
 const vscode = require("vscode");
 const { msgs } = require("../utils/msgs");
-const { mapEnumsToQuickPick, getTemplates, copyTemplateByName, waitFor } = require("../utils/misc");
+const { mapEnumsToQuickPick, getTemplates, copyTemplateByName, waitFor, hasExistingFiles } = require("../utils/misc");
 const { relative } = require("path");
 const { Project } = require("../Project");
 const { DeviceManager } = require("../Watcher/DeviceManager");
@@ -292,7 +292,16 @@ class Commands {
         const device = this.pymakr.devicesStore.get().find((d) => d.name === match[1]);
         const project = /** @type {Project} */ ({ folder: projectUri.fsPath });
         this.commands.downloadProject({ device, project });
-      } else copyTemplateByName(templateName, projectUri.fsPath);
+      } else {
+        const hasFiles = hasExistingFiles(projectUri.fsPath, ["pymakr.conf"]);
+        const choice =
+          hasFiles &&
+          (await vscode.window.showQuickPick(["Keep", "Overwrite"], {
+            title: "Folder has existing files. How do you wish to proceed?",
+          }));
+        const overwrite = choice === "Overwrite";
+        copyTemplateByName(templateName, projectUri.fsPath, overwrite);
+      }
     },
 
     /**

src/utils/misc.js

@@ -20,6 +20,14 @@ const once = (fn, context) => {
   };
 };
 
+/**
+ * Checks if a dir has existing files.
+ * @param {string} path
+ * @param {string[]} ignore
+ * @returns {Boolean}
+ */
+const hasExistingFiles = (path, ignore = []) => !!readdirSync(path).filter((file) => !ignore.includes(file)).length;
+
 /**
  * if the input isn't an array, an array will be returned containing the input
  * if the input is an array, the input will be returned
@@ -277,8 +285,10 @@ const createThrottledFunction = (fn, time) => {
 };
 
 const getTemplates = () => readdirSync(TEMPLATES_PATH).map((name) => ({ name, path: resolve(TEMPLATES_PATH, name) }));
-const copyTemplateByName = (name, destination) => copyTemplateByPath(resolve(TEMPLATES_PATH, name), destination);
-const copyTemplateByPath = (path, destination) => cpSync(path, destination, { recursive: true });
+const copyTemplateByName = (name, destination, overwrite) =>
+  copyTemplateByPath(resolve(TEMPLATES_PATH, name), destination, overwrite);
+const copyTemplateByPath = (path, destination, overwrite) =>
+  cpSync(path, destination, { recursive: true, force: overwrite });
 
 /**
  * converts {foo:FOO, bar:BAR} to ['foo=FOO', 'bar=BAR']
@@ -380,6 +390,7 @@ const createQueue = () => {
  */
 
 module.exports = {
+  hasExistingFiles,
   dynamicPromiseAll,
   onResolveAll,
   objToSerializedEntries,