Some linting issues

Author: rhpvorderman

setup.py

@@ -45,7 +45,7 @@
     zip_safe=False,
     packages=find_packages('src'),
     package_dir={'': 'src'},
-    package_data = {'isal': ['*.pxd']},
+    package_data={'isal': ['*.pxd']},
     url="https://github.com/rhpvorderman/python-isal",
     classifiers=[
         "Programming Language :: Python :: 3 :: Only",
@@ -64,7 +64,7 @@
     ext_modules=[
         Extension("isal.isal_zlib", ["src/isal/isal_zlib.pyx"],
                   libraries=["isal"], **EXTENSION_OPTS),
-        Extension("isal._isal", ["src/isal/_isal.pyx"], 
+        Extension("isal._isal", ["src/isal/_isal.pyx"],
                   libraries=["isal"], **EXTENSION_OPTS),
     ]
 )

src/isal/igzip.py

@@ -22,33 +22,28 @@
 Library to speed up its methods."""
 
 import argparse
+import gzip
 import io
 import os
+from gzip import BadGzipFile
+
 import _compression
 
-# We import a copy of the gzip module so we can use that to define the classes
-# here and replace  the zlib module with the isal_zlib module. This way the
-# zlib module will not be replaced for the original zlib module. So IGzipFile
-# and gzip.GzipFile can be used in the same code.
-# Also this reuses as much code from the stdlib without copying it.
 from . import isal_zlib
 
+__all__ = ["BadGzipFile", "IGzipFile", "open", "compress", "decompress"]
+
 _COMPRESS_LEVEL_FAST = isal_zlib.ISAL_BEST_SPEED
 _COMPRESS_LEVEL_TRADEOFF = isal_zlib.ISAL_DEFAULT_COMPRESSION
 _COMPRESS_LEVEL_BEST = isal_zlib.ISAL_BEST_COMPRESSION
 _BLOCK_SIZE = 64*1024
 
-import gzip
-from gzip import BadGzipFile
-
-__all__ = ["BadGzipFile", "IGzipFile", "open", "compress", "decompress"]
-
 
 # The open method was copied from the python source with minor adjustments.
 def open(filename, mode="rb", compresslevel=_COMPRESS_LEVEL_TRADEOFF,
          encoding=None, errors=None, newline=None):
     """Open a gzip-compressed file in binary or text mode. This uses the isa-l
-    library for optimised speed.
+    library for optimized speed.
 
     The filename argument can be an actual filename (a str or bytes object), or
     an existing file object to read from or write to.
@@ -71,7 +66,8 @@ def open(filename, mode="rb", compresslevel=_COMPRESS_LEVEL_TRADEOFF,
             raise ValueError("Invalid mode: %r" % (mode,))
     else:
         if encoding is not None:
-            raise ValueError("Argument 'encoding' not supported in binary mode")
+            raise ValueError(
+                "Argument 'encoding' not supported in binary mode")
         if errors is not None:
             raise ValueError("Argument 'errors' not supported in binary mode")
         if newline is not None:
@@ -119,7 +115,7 @@ def __repr__(self):
     def flush(self, zlib_mode=isal_zlib.Z_SYNC_FLUSH):
         super().flush(zlib_mode)
 
-    def write(self,data):
+    def write(self, data):
         self._check_not_closed()
         if self.mode != gzip.WRITE:
             import errno
@@ -153,15 +149,15 @@ def __init__(self, fp):
         super().__init__(fp, isal_zlib.decompressobj,
                          wbits=16 + isal_zlib.MAX_WBITS)
 
-    
 
 # Plagiarized from gzip.py from python's stdlib.
 def compress(data, compresslevel=_COMPRESS_LEVEL_BEST, *, mtime=None):
     """Compress data in one shot and return the compressed string.
     Optional argument is the compression level, in range of 0-3.
     """
     buf = io.BytesIO()
-    with IGzipFile(fileobj=buf, mode='wb', compresslevel=compresslevel, mtime=mtime) as f:
+    with IGzipFile(fileobj=buf, mode='wb',
+                   compresslevel=compresslevel, mtime=mtime) as f:
         f.write(data)
     return buf.getvalue()
 
@@ -220,7 +216,5 @@ def main():
                     out_file.write(block)
 
 
-
-
 if __name__ == "__main__":
-    main()
+    main()

tests/test_isal.py

@@ -41,6 +41,7 @@
 # Wbits for ZLIB compression, GZIP compression, and RAW compressed streams
 WBITS_RANGE = list(range(9, 16)) + list(range(25, 32)) + list(range(-15, -8))
 
+
 @pytest.mark.parametrize(["data_size", "value"],
                          itertools.product(DATA_SIZES, SEEDS))
 def test_crc32(data_size, value):
@@ -71,8 +72,9 @@ def test_decompress_zlib(data_size, level):
     decompressed = isal_zlib.decompress(compressed)
     assert decompressed == data
 
+
 @pytest.mark.parametrize(["data_size", "level", "wbits", "memLevel"],
-                         itertools.product([128* 1024], range(4),
+                         itertools.product([128 * 1024], range(4),
                                            WBITS_RANGE, range(1, 10)))
 def test_decompress_wbits(data_size, level, wbits, memLevel):
     data = DATA[:data_size]
@@ -81,6 +83,7 @@ def test_decompress_wbits(data_size, level, wbits, memLevel):
     decompressed = isal_zlib.decompress(compressed, wbits=wbits)
     assert data == decompressed
 
+
 @pytest.mark.parametrize(["data_size", "level"],
                          itertools.product(DATA_SIZES, range(4)))
 def test_decompress_isal_zlib(data_size, level):
@@ -92,7 +95,7 @@ def test_decompress_isal_zlib(data_size, level):
 
 
 @pytest.mark.parametrize(["data_size", "level", "wbits", "memLevel"],
-                         itertools.product([128* 1024], range(4),
+                         itertools.product([128 * 1024], range(4),
                                            WBITS_RANGE, range(1, 10)))
 def test_compress_compressobj(data_size, level, wbits, memLevel):
     data = DATA[:data_size]
@@ -110,7 +113,7 @@ def test_compress_compressobj(data_size, level, wbits, memLevel):
 
 
 @pytest.mark.parametrize(["data_size", "level", "wbits", "memLevel"],
-                         itertools.product([128* 1024], range(4),
+                         itertools.product([128 * 1024], range(4),
                                            WBITS_RANGE, range(1, 10)))
 def test_decompress_decompressobj(data_size, level, wbits, memLevel):
     data = DATA[:data_size]