Skip to content

Commit 23d15fe

Browse files
committed
Perform twine check with tox as well
1 parent ece58e5 commit 23d15fe

File tree

2 files changed

+14
-31
lines changed

2 files changed

+14
-31
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,14 @@ jobs:
2525
run: pip install tox
2626
- name: Lint
2727
run: tox -e lint
28-
docs_mypy:
28+
29+
package-checks:
2930
strategy:
3031
matrix:
3132
tox_env:
3233
- docs
3334
- mypy
35+
- twine_check
3436
needs: lint
3537
runs-on: ubuntu-20.04
3638
steps:
@@ -50,35 +52,6 @@ jobs:
5052
env:
5153
PYTHON_ISAL_LINK_DYNAMIC: True
5254

53-
twine_check:
54-
needs: lint
55-
runs-on: ${{ matrix.os }}
56-
strategy:
57-
matrix:
58-
python-version:
59-
- 3.6
60-
os: ["ubuntu-latest" ]
61-
steps:
62-
- uses: actions/[email protected]
63-
with:
64-
submodules: recursive
65-
- name: Set up Python ${{ matrix.python-version }}
66-
uses: actions/[email protected]
67-
with:
68-
python-version: ${{ matrix.python-version }}
69-
- name: Install build dependencies (Linux) # Yasm in pypa/manylinux images.
70-
run: sudo apt install yasm
71-
if: runner.os == 'Linux'
72-
- name: Install build dependencies (Macos)
73-
run: brew install yasm automake autoconf
74-
if: runner.os == 'macOS'
75-
- name: Install twine, cython wheel and upgrade setuptools
76-
run: pip install --upgrade twine cython wheel setuptools
77-
- name: create dists
78-
run: python setup.py sdist bdist_wheel
79-
- name: check dists
80-
run: twine check dist/*
81-
8255
test-static:
8356
needs: lint
8457
runs-on: ${{ matrix.os }}
@@ -142,7 +115,7 @@ jobs:
142115
deploy:
143116
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
144117
runs-on: ${{ matrix.os }}
145-
needs: [lint, docs, test-static, test-dynamic, twine_check]
118+
needs: [lint, package-checks, test-static, test-dynamic]
146119
strategy:
147120
matrix:
148121
os: [ "macos-latest", "ubuntu-latest" ]

tox.ini

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,16 @@ deps=mypy
5252
commands =
5353
mypy src/ tests/
5454

55+
[testenv:twine_check]
56+
deps=wheel
57+
setuptools
58+
twine
59+
cython
60+
skip_install=True
61+
commands =
62+
python setup.py sdist bdist_wheel
63+
twine check dist/*
64+
5565
# Documentation should build on python version 3
5666
[testenv:docs]
5767
deps=-r requirements-docs.txt

0 commit comments

Comments
 (0)