Skip to content

Commit 39cc70e

Browse files
authored
Merge pull request #204 from pycompression/builddetails
Add a development chapter
2 parents d040bb1 + 726ceed commit 39cc70e

File tree

5 files changed

+30
-15
lines changed

5 files changed

+30
-15
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ name: Continous integration
22

33
on:
44
pull_request:
5-
paths-ignore:
6-
- 'docs/**'
7-
- '*.rst'
85
push:
96
branches:
107
- develop

README.rst

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,24 @@ are also very welcome. Please report them on the `github issue tracker
166166

167167
.. contributing end
168168
169+
Development
170+
-----------
171+
.. development start
172+
173+
The repository needs to be cloned recursively to make sure the
174+
`ISA-L <https://github.com/intel/isa-l>`_ repository is checked out:
175+
``git clone --recursive https://github.com/pycompression/python-isal.git``. If
176+
the repository is already checked out you can use ``git submodule update --init``.
177+
178+
Patches should be made on a feature branch. To run the testing install ``tox``
179+
with ``pip install tox`` and run the commands ``tox -e lint`` and
180+
``tox``. That will run most of the testing that is also performed by the CI.
181+
For changes to the documentation run ``tox -e docs``. For changes to the C
182+
code please also run ``tox -e asan`` to check for memory leaks. This requires
183+
libasan to be installed.
184+
185+
.. development end
186+
169187
Acknowledgements
170188
----------------
171189

docs/conf.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,27 +4,20 @@
44
# list see the documentation:
55
# https://www.sphinx-doc.org/en/master/usage/configuration.html
66

7-
from distutils.dist import DistributionMetadata
8-
from pathlib import Path
9-
10-
import pkg_resources
7+
from isal import __version__
118

129
# -- Project information -----------------------------------------------------
1310

1411
# Get package information from the installed package.
15-
package = pkg_resources.get_distribution("isal")
16-
metadata_file = Path(package.egg_info) / Path(package.PKG_INFO)
17-
metadata = DistributionMetadata(path=str(metadata_file))
1812

1913
project = 'python-isal'
2014
copyright = '2020, Leiden University Medical Center'
2115
author = 'Leiden University Medical Center'
2216

2317
# The short X.Y version
24-
version = package.parsed_version.base_version
18+
version = __version__
2519
# The full version, including alpha/beta/rc tags
26-
release = package.version
27-
20+
release = __version__
2821

2922
# -- General configuration ---------------------------------------------------
3023

docs/index.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,13 @@ Contributing
158158
:start-after: .. contributing start
159159
:end-before: .. contributing end
160160

161+
===========
162+
Development
163+
===========
164+
.. include:: includes/README.rst
165+
:start-after: .. development start
166+
:end-before: .. development end
167+
161168
================
162169
Acknowledgements
163170
================

requirements-docs.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
sphinx
2-
setuptools
32
sphinx-rtd-theme
4-
sphinx-argparse
3+
# See https://github.com/sphinx-doc/sphinx-argparse/issues/56
4+
sphinx-argparse <0.5.0

0 commit comments

Comments
 (0)