Skip to content

Commit 4eba72a

Browse files
committed
Remove python 3.7 from supported versions
1 parent b241cd4 commit 4eba72a

File tree

3 files changed

+9
-16
lines changed

3 files changed

+9
-16
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ jobs:
1919
- uses: actions/[email protected]
2020
with:
2121
submodules: recursive
22-
- name: Set up Python 3.7
22+
- name: Set up Python 3.8
2323
uses: actions/[email protected]
2424
with:
25-
python-version: 3.7
25+
python-version: 3.8
2626
- name: Install tox
2727
run: pip install tox
2828
- name: Lint
@@ -39,10 +39,10 @@ jobs:
3939
- uses: actions/[email protected]
4040
with:
4141
submodules: recursive
42-
- name: Set up Python 3.7
42+
- name: Set up Python 3.8
4343
uses: actions/[email protected]
4444
with:
45-
python-version: 3.7
45+
python-version: 3.8
4646
- name: Install isal
4747
run: sudo apt-get install libisal-dev
4848
- name: Install tox and upgrade setuptools and pip
@@ -57,20 +57,18 @@ jobs:
5757
strategy:
5858
matrix:
5959
python-version:
60-
- "3.7"
6160
- "3.8"
6261
- "3.9"
6362
- "3.10"
6463
- "3.11"
65-
- "pypy-3.7"
6664
- "pypy-3.8"
6765
- "pypy-3.9"
6866
os: ["ubuntu-latest"]
6967
include:
7068
- os: "macos-latest"
71-
python-version: 3.7
69+
python-version: 3.8
7270
- os: "windows-latest"
73-
python-version: 3.7
71+
python-version: 3.8
7472
steps:
7573
- uses: actions/[email protected]
7674
with:
@@ -106,7 +104,7 @@ jobs:
106104
strategy:
107105
matrix:
108106
python_version:
109-
- "3.7"
107+
- "3.8"
110108
steps:
111109
- uses: actions/[email protected]
112110
with:

setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,6 @@ def build_isa_l():
158158
classifiers=[
159159
"Programming Language :: Python :: 3 :: Only",
160160
"Programming Language :: Python :: 3",
161-
"Programming Language :: Python :: 3.7",
162161
"Programming Language :: Python :: 3.8",
163162
"Programming Language :: Python :: 3.9",
164163
"Programming Language :: Python :: 3.10",
@@ -173,6 +172,6 @@ def build_isa_l():
173172
"Operating System :: MacOS",
174173
"Operating System :: Microsoft :: Windows",
175174
],
176-
python_requires=">=3.7", # We use METH_FASTCALL
175+
python_requires=">=3.8", # BadGzipFile imported
177176
ext_modules=EXTENSIONS
178177
)

src/isal/igzip.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,7 @@
5656
FTEXT, FHCRC, FEXTRA, FNAME, FCOMMENT = 1, 2, 4, 8, 16
5757
READ, WRITE = 1, 2
5858

59-
try:
60-
BadGzipFile = gzip.BadGzipFile # type: ignore
61-
except AttributeError: # Versions lower than 3.8 do not have BadGzipFile
62-
BadGzipFile = OSError # type: ignore
63-
59+
BadGzipFile = gzip.BadGzipFile # type: ignore
6460

6561
# The open method was copied from the CPython source with minor adjustments.
6662
def open(filename, mode="rb", compresslevel=_COMPRESS_LEVEL_TRADEOFF,

0 commit comments

Comments
 (0)