Make sure zdict cannot be excessively large

rhpvorderman · rhpvorderman · commit 59620faeebab · 2023-10-11T08:48:49.000+02:00
diff --git a/src/isal/isal_zlibmodule.c b/src/isal/isal_zlibmodule.c
@@ -396,7 +396,7 @@ ParallelCompress_compress_and_crc(ParallelCompress *self,
         return NULL;
     }
 
-    if (data.len > UINT32_MAX) {
+    if (data.len + zdict.len > UINT32_MAX) {
         PyErr_Format(PyExc_OverflowError, 
                      "Can only compress %d bytes of data", UINT32_MAX);
         goto error;

Original file line number	Diff line number	Diff line change
`@@ -396,7 +396,7 @@ ParallelCompress_compress_and_crc(ParallelCompress *self,`
`396`	`396`	`return NULL;`
`397`	`397`	`}`
`398`	`398`
`399`		`- if (data.len > UINT32_MAX) {`
	`399`	`+ if (data.len + zdict.len > UINT32_MAX) {`
`400`	`400`	`PyErr_Format(PyExc_OverflowError,`
`401`	`401`	`"Can only compress %d bytes of data", UINT32_MAX);`
`402`	`402`	`goto error;`