Skip to content

Commit 9133069

Browse files
authored
Merge pull request #66 from pycompression/pypydynamic
Make sure conda pypy installations should work.
2 parents cdfc4f6 + 8c0bd03 commit 9133069

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ jobs:
100100

101101
test-arch:
102102
if: startsWith(github.ref, 'refs/tags') || github.ref == 'refs/heads/develop' || github.ref == 'refs/heads/main'
103-
name: Test on ${{ matrix.distro }} ${{ matrix.arch }}
104103
runs-on: "ubuntu-latest"
105104
needs: lint
106105
strategy:
@@ -136,6 +135,10 @@ jobs:
136135
strategy:
137136
matrix:
138137
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
138+
python_version: ["python"]
139+
include:
140+
- os: "ubuntu-latest"
141+
python_version: "pypy"
139142
steps:
140143
- uses: actions/[email protected]
141144
with:
@@ -145,12 +148,12 @@ jobs:
145148
with:
146149
channels: conda-forge,defaults
147150
- name: Install requirements (universal)
148-
run: conda install isa-l python tox
151+
run: conda install isa-l ${{ matrix.python_version}} tox
149152
- name: Set MSVC developer prompt
150153
uses: ilammy/[email protected]
151154
if: runner.os == 'Windows'
152155
- name: Run tests (dynamic link)
153-
run: tox -e py3
156+
run: tox
154157
env:
155158
PYTHON_ISAL_LINK_DYNAMIC: True
156159

setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ def build_extension(self, ext):
6262
for prefix in possible_prefixes:
6363
if Path(prefix, "include", "isa-l").exists():
6464
ext.include_dirs = [os.path.join(prefix, "include")]
65+
ext.library_dirs = [os.path.join(prefix, "lib")]
6566
break # Only one include directory is needed.
6667
# On windows include is in Library apparently
6768
elif Path(prefix, "Library", "include", "isa-l").exists():

tox.ini

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,9 @@ passenv=
1010
commands =
1111
# Create HTML coverage report for humans and xml coverage report for external services.
1212
coverage run --source=isal -m py.test tests
13-
coverage html
14-
coverage xml
13+
# Ignore errors during report generation. Pypy does not generate proper coverage reports.
14+
coverage html -i
15+
coverage xml -i
1516

1617
[testenv:coverage]
1718
# Separate test environment for cython coverage.

0 commit comments

Comments
 (0)