Skip to content

Commit 986b077

Browse files
committed
Only get PyBUF_SIMPLE buffers
This is the same as in zlibmodule.c
1 parent ca62b32 commit 986b077

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

src/isal/isal_zlib.pyx

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ from .crc cimport crc32_gzip_refl
3131
from .igzip_lib cimport *
3232
from libc.stdint cimport UINT64_MAX, UINT32_MAX
3333
from cpython.mem cimport PyMem_Malloc, PyMem_Realloc, PyMem_Free
34-
from cpython.buffer cimport PyBUF_READ, PyBUF_C_CONTIGUOUS, PyObject_GetBuffer, \
35-
PyBuffer_Release
34+
from cpython.buffer cimport PyBUF_SIMPLE, PyObject_GetBuffer, PyBuffer_Release
3635
from cpython.bytes cimport PyBytes_FromStringAndSize
3736
from cpython.long cimport PyLong_AsUnsignedLongMask
3837

@@ -97,7 +96,7 @@ def adler32(data, value = 1):
9796
cdef unsigned long init = PyLong_AsUnsignedLongMask(value)
9897
cdef Py_buffer buffer_data
9998
cdef Py_buffer* buffer = &buffer_data
100-
if PyObject_GetBuffer(data, buffer, PyBUF_READ & PyBUF_C_CONTIGUOUS) != 0:
99+
if PyObject_GetBuffer(data, buffer, PyBUF_SIMPLE) != 0:
101100
raise TypeError("Failed to get buffer")
102101
try:
103102
if buffer.len > UINT64_MAX:
@@ -117,7 +116,7 @@ def crc32(data, value = 0):
117116
cdef unsigned long init = PyLong_AsUnsignedLongMask(value)
118117
cdef Py_buffer buffer_data
119118
cdef Py_buffer* buffer = &buffer_data
120-
if PyObject_GetBuffer(data, buffer, PyBUF_READ & PyBUF_C_CONTIGUOUS) != 0:
119+
if PyObject_GetBuffer(data, buffer, PyBUF_SIMPLE) != 0:
121120
raise TypeError("Failed to get buffer")
122121
try:
123122
if buffer.len > UINT64_MAX:
@@ -218,7 +217,7 @@ def compress(data,
218217
# initialise input
219218
cdef Py_buffer buffer_data
220219
cdef Py_buffer* buffer = &buffer_data
221-
if PyObject_GetBuffer(data, buffer, PyBUF_READ & PyBUF_C_CONTIGUOUS) != 0:
220+
if PyObject_GetBuffer(data, buffer, PyBUF_SIMPLE) != 0:
222221
raise TypeError("Failed to get buffer")
223222
cdef Py_ssize_t ibuflen = buffer.len
224223
cdef unsigned char * ibuf = <unsigned char*>buffer.buf
@@ -295,7 +294,7 @@ def decompress(data,
295294
# initialise input
296295
cdef Py_buffer buffer_data
297296
cdef Py_buffer* buffer = &buffer_data
298-
if PyObject_GetBuffer(data, buffer, PyBUF_READ & PyBUF_C_CONTIGUOUS) != 0:
297+
if PyObject_GetBuffer(data, buffer, PyBUF_SIMPLE) != 0:
299298
raise TypeError("Failed to get buffer")
300299
cdef Py_ssize_t ibuflen = buffer.len
301300
cdef unsigned char * ibuf = <unsigned char*>buffer.buf
@@ -439,7 +438,7 @@ cdef class Compress:
439438
# initialise input
440439
cdef Py_buffer buffer_data
441440
cdef Py_buffer* buffer = &buffer_data
442-
if PyObject_GetBuffer(data, buffer, PyBUF_READ & PyBUF_C_CONTIGUOUS) != 0:
441+
if PyObject_GetBuffer(data, buffer, PyBUF_SIMPLE) != 0:
443442
raise TypeError("Failed to get buffer")
444443
cdef Py_ssize_t ibuflen = buffer.len
445444
cdef unsigned char * ibuf = <unsigned char*>buffer.buf
@@ -618,7 +617,7 @@ cdef class Decompress:
618617
# initialise input
619618
cdef Py_buffer buffer_data
620619
cdef Py_buffer* buffer = &buffer_data
621-
if PyObject_GetBuffer(data, buffer, PyBUF_READ & PyBUF_C_CONTIGUOUS) != 0:
620+
if PyObject_GetBuffer(data, buffer, PyBUF_SIMPLE) != 0:
622621
raise TypeError("Failed to get buffer")
623622
cdef Py_ssize_t ibuflen = buffer.len
624623
cdef unsigned char * ibuf = <unsigned char*>buffer.buf
@@ -674,7 +673,7 @@ cdef class Decompress:
674673

675674
cdef Py_buffer buffer_data
676675
cdef Py_buffer* buffer = &buffer_data
677-
if PyObject_GetBuffer(self.unconsumed_tail, buffer, PyBUF_READ & PyBUF_C_CONTIGUOUS) != 0:
676+
if PyObject_GetBuffer(self.unconsumed_tail, buffer, PyBUF_SIMPLE) != 0:
678677
raise TypeError("Failed to get buffer")
679678
cdef Py_ssize_t ibuflen = buffer.len
680679
cdef unsigned char * ibuf = <unsigned char*>buffer.buf

0 commit comments

Comments
 (0)