Add missing decref when error is thrown in decompressobj

rhpvorderman · rhpvorderman · commit b78ef86d8371 · 2023-10-26T08:22:46.000+02:00
diff --git a/src/isal/isal_zlibmodule.c b/src/isal/isal_zlibmodule.c
@@ -793,6 +793,7 @@ isal_zlib_decompressobj_impl(PyObject *module, int wbits, PyObject *zdict)
     err = wbits_to_flag_and_hist_bits_inflate(wbits, &hist_bits, &flag);
     if (err < 0) {
         PyErr_Format(PyExc_ValueError, "Invalid wbits value: %d", wbits);
+        Py_DECREF(self);
         return NULL;
     }
     else if (err == 0) {

Original file line number	Diff line number	Diff line change
`@@ -793,6 +793,7 @@ isal_zlib_decompressobj_impl(PyObject module, int wbits, PyObject zdict)`
`793`	`793`	`err = wbits_to_flag_and_hist_bits_inflate(wbits, &hist_bits, &flag);`
`794`	`794`	`if (err < 0) {`
`795`	`795`	`PyErr_Format(PyExc_ValueError, "Invalid wbits value: %d", wbits);`
	`796`	`+ Py_DECREF(self);`
`796`	`797`	`return NULL;`
`797`	`798`	`}`
`798`	`799`	`else if (err == 0) {`