Skip to content

Commit e022394

Browse files
committed
Test more code paths on igzip_threaded
1 parent 9960d5b commit e022394

File tree

3 files changed

+22
-3
lines changed

3 files changed

+22
-3
lines changed

src/isal/igzip_threaded.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,6 @@ def readinto(self, b):
129129
def readable(self) -> bool:
130130
return True
131131

132-
def writable(self) -> bool:
133-
return False
134-
135132
def tell(self) -> int:
136133
if self._closed:
137134
raise ValueError("I/O operation on closed file")

tests/test

Whitespace-only changes.

tests/test_igzip_threaded.py

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,32 @@ def test_close_reader():
8787
f = igzip_threaded.open(TEST_FILE, "rb")
8888
f.close()
8989
assert f.closed
90+
# Make sure double closing does not raise errors
91+
f.close()
9092

9193

9294
def test_close_writer():
9395
raw = tempfile.TemporaryFile()
9496
f = igzip_threaded.open(raw, "wb")
9597
f.close()
9698
assert f.closed
99+
# Make sure double closing does not raise errors
100+
f.close()
101+
102+
103+
def test_reader_not_writable():
104+
with igzip_threaded.open(TEST_FILE, "rb") as f:
105+
assert not f.writable()
106+
107+
108+
def test_writer_not_readable():
109+
with tempfile.TemporaryFile(mode="wb") as tmp:
110+
with igzip_threaded.open(tmp, "wb") as f:
111+
assert not f.readable()
112+
113+
114+
def test_writer_wrong_level():
115+
with pytest.raises(ValueError) as error:
116+
igzip_threaded.open("test", mode="wb", compresslevel=42)
117+
error.match("Invalid compression level")
118+
error.match("42")

0 commit comments

Comments
 (0)