Skip to content

Commit 4397293

Browse files
authored
ci: remove workaround for free-threaded build w. maturin (#172)
1 parent 0590d09 commit 4397293

File tree

1 file changed

+7
-26
lines changed

1 file changed

+7
-26
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,9 @@ jobs:
331331

332332
- run: |
333333
pip install -U twine
334-
twine check --strict crates/jiter-python/dist/*
334+
# FIXME: restore `twine` check when metadata version 2.4 (used by `maturin`) supported by `twine`,
335+
# see https://github.com/pypa/twine/pull/1180
336+
# twine check --strict crates/jiter-python/dist/*
335337
336338
- uses: actions/upload-artifact@v4
337339
with:
@@ -362,10 +364,6 @@ jobs:
362364
interpreter: "3.8"
363365
- os: macos
364366
interpreter: "3.9"
365-
# windows free-threaded build has a problematic wheel name,
366-
# needs something like https://github.com/PyO3/maturin/pull/2325 to fix
367-
- os: windows
368-
interpreter: "3.13t"
369367

370368
runs-on: ${{ matrix.runs-on }}
371369
steps:
@@ -384,29 +382,10 @@ jobs:
384382
with:
385383
components: llvm-tools
386384

387-
# linux: builds are done inside manylinux docker images, need to help maturin-action
388-
# find the right path
389-
#
390-
# TODO, would be nice to remove, see
391-
# https://github.com/PyO3/maturin-action/issues/300
392-
- if: ${{ matrix.os == 'linux' }}
393-
id: resolve-interpreter
394-
name: resolve interpreter
395-
run: |
396-
echo python-path=/opt/python/$(python -c "print({
397-
'3.8': 'cp38-cp38',
398-
'3.9': 'cp39-cp39',
399-
'3.10': 'cp310-cp310',
400-
'3.11': 'cp311-cp311',
401-
'3.12': 'cp312-cp312',
402-
'3.13': 'cp313-cp313',
403-
'3.13t': 'cp313-cp313t',
404-
}['${{ matrix.interpreter }}'])")/bin/python >> $GITHUB_OUTPUT
405-
406385
- name: build pgo wheel
407386
uses: ./.github/actions/build-pgo-wheel
408387
with:
409-
interpreter: ${{ matrix.os == 'linux' && steps.resolve-interpreter.outputs.python-path || steps.setup-python.outputs.python-path }}
388+
interpreter: ${{ matrix.interpreter }}
410389
rust-toolchain: ${{ steps.rust-toolchain.outputs.name }}
411390

412391
- run: ${{ matrix.ls || 'ls -lh' }} crates/jiter-python/dist/
@@ -584,7 +563,9 @@ jobs:
584563

585564
- run: pip install -U twine
586565
- run: ls -l dist/
587-
- run: twine check --strict dist/*
566+
# FIXME: restore `twine` check when metadata version 2.4 (used by `maturin`) supported by `twine`
567+
# see https://github.com/pypa/twine/pull/1180
568+
# - run: twine check --strict dist/*
588569

589570
- name: upload to pypi
590571
uses: pypa/gh-action-pypi-publish@release/v1

0 commit comments

Comments
 (0)