Skip to content

Commit 120df1f

Browse files
authored
Move creation of span down on cli (#1298)
1 parent d844dd4 commit 120df1f

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

logfire/_internal/cli/__init__.py

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -410,18 +410,17 @@ def _main(args: list[str] | None = None) -> None:
410410
def log_trace_id(response: requests.Response, context: ContextCarrier, *args: Any, **kwargs: Any) -> None:
411411
logger.debug('context=%s url=%s', context, response.url)
412412

413-
with tracer.start_as_current_span('logfire._internal.cli'):
414-
if namespace.version:
415-
version_callback()
416-
elif namespace.func == parse_info:
413+
if namespace.version:
414+
version_callback()
415+
elif namespace.func in (parse_info, parse_run):
416+
namespace.func(namespace)
417+
else:
418+
with tracer.start_as_current_span('logfire._internal.cli'), requests.Session() as session:
419+
context = get_context()
420+
session.hooks = {'response': functools.partial(log_trace_id, context=context)}
421+
session.headers.update(context)
422+
namespace._session = session
417423
namespace.func(namespace)
418-
else:
419-
with requests.Session() as session:
420-
context = get_context()
421-
session.hooks = {'response': functools.partial(log_trace_id, context=context)}
422-
session.headers.update(context)
423-
namespace._session = session
424-
namespace.func(namespace)
425424

426425

427426
def main(args: list[str] | None = None) -> None:

0 commit comments

Comments
 (0)