Fix logfire_api requiring OpenTelemetry SDK (#1310)

Author: alexmojaki

logfire-api/logfire_api/__init__.py

@@ -5,7 +5,6 @@
 from contextlib import contextmanager, nullcontext
 from typing import Any, ContextManager, Literal, TYPE_CHECKING, Sequence
 from unittest.mock import MagicMock
-from opentelemetry.sdk.trace import ReadableSpan
 
 try:
     logfire_module = importlib.import_module('logfire')
@@ -20,11 +19,24 @@
         def configure(*args, **kwargs): ...
 
         class LogfireSpan:
-            def __init__(self, *args, **kwargs):
-                self._readable_span = ReadableSpan(name='')
-
             def __getattr__(self, attr):
-                return getattr(self._readable_span, attr, MagicMock())
+                return MagicMock()
+
+            @property
+            def name(self):
+                return ''
+
+            @property
+            def attributes(self):
+                return {}
+
+            @property
+            def events(self):
+                return ()
+
+            @property
+            def links(self):
+                return ()
 
             def __enter__(self):
                 return self

tests/otel_integrations/test_openai_agents.py

@@ -887,6 +887,7 @@ async def test_chat_completions(exporter: TestExporter):
                         'store': None,
                         'include_usage': None,
                         'response_include': None,
+                        'top_logprobs': None,
                         'extra_query': None,
                         'extra_body': None,
                         'extra_headers': None,

tests/test_logfire_api.py

@@ -3,13 +3,11 @@
 import importlib
 import sys
 from pathlib import Path
-from types import MappingProxyType, ModuleType
+from types import ModuleType
 from typing import Callable
 from unittest.mock import MagicMock
 
 import pytest
-from opentelemetry.sdk.resources import Resource
-from opentelemetry.trace import SpanKind, Status
 from pydantic import __version__ as pydantic_version
 
 from logfire._internal.utils import get_version
@@ -72,19 +70,12 @@ def test_runtime(logfire_api_factory: Callable[[], ModuleType], module_name: str
         assert isinstance(span, logfire_api.LogfireSpan)
         span.set_attribute('foo', 'bar')
 
+        assert span.name == '' if module_name == 'logfire_api.' else 'test span'
         if module_name == 'logfire_api.':
-            assert span.context is None
-            assert span.name == ''
-            assert span.parent is None
-            assert isinstance(span.resource, Resource)
-            assert isinstance(span.attributes, MappingProxyType)
-            assert span.events == ()
-            assert span.links == ()
-            assert isinstance(span.kind, SpanKind)
-            assert isinstance(span.status, Status)
-            assert span.start_time is None
-            assert span.end_time is None
-            assert span.instrumentation_scope is None
+            assert span.attributes == {}
+        assert span.events == ()
+        assert span.links == ()
+        assert span.resource.attributes
 
     logfire__all__.remove('LogfireSpan')
     logfire__all__.remove('span')