Skip to content

Commit 5a7ddc4

Browse files
authored
Add missing service_version field to _LogfireConfigData so that it gets copied into subprocesses (#401)
1 parent 108ae4b commit 5a7ddc4

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

logfire-api/logfire_api/_internal/config.pyi

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ class _LogfireConfigData:
124124
token: str | None
125125
project_name: str | None
126126
service_name: str
127+
service_version: str | None
127128
trace_sample_rate: float
128129
console: ConsoleOptions | Literal[False] | None
129130
show_summary: bool

logfire/_internal/config.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,9 @@ class _LogfireConfigData:
319319
service_name: str
320320
"""The name of this service"""
321321

322+
service_version: str | None
323+
"""The version of this service"""
324+
322325
trace_sample_rate: float
323326
"""The sampling ratio for spans"""
324327

@@ -329,7 +332,7 @@ class _LogfireConfigData:
329332
"""Whether to show the summary when starting a new project"""
330333

331334
data_dir: Path
332-
"""The directory to store Logfire config in"""
335+
"""The directory to store Logfire data in"""
333336

334337
id_generator: IdGenerator
335338
"""The ID generator to use"""

0 commit comments

Comments
 (0)