Skip to content

Commit 660efbd

Browse files
authored
Reformat message with old attributes as well (#919)
1 parent edb88f2 commit 660efbd

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

logfire/_internal/integrations/openai_agents.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -252,16 +252,14 @@ def on_ending(self):
252252
template = logfire_span.message_template
253253
assert template
254254
new_attrs = attributes_from_span_data(self.span_data, template) # type: ignore
255-
try:
256-
message = logfire_format(template, new_attrs, NOOP_SCRUBBER)
257-
except Exception: # pragma: no cover
258-
message = logfire_span.message
259255
if error := self.error:
260256
new_attrs['error'] = error
261-
message += f' failed: {error["message"]}'
262257
logfire_span.set_level('error')
263-
logfire_span.message = message
264258
logfire_span.set_attributes(new_attrs)
259+
message = logfire_format(template, dict(logfire_span.attributes or {}), NOOP_SCRUBBER)
260+
if error:
261+
message += f' failed: {error["message"]}'
262+
logfire_span.message = message
265263

266264
@property
267265
def trace_id(self) -> str:

0 commit comments

Comments
 (0)