Skip to content

Commit 6b263c0

Browse files
authored
Fix compatibility with Pydantic dropping 3.8 (#804)
Pydantic dropped support for Python 3.9 (and will be effective when 2.11 is released). Because the Logfire SDK still supports 3.8 and as we pin Pydantic to the main branch in our dev dependencies, we need to add a conditional based on the python version.
1 parent cccccd0 commit 6b263c0

File tree

3 files changed

+51
-14
lines changed

3 files changed

+51
-14
lines changed

.github/workflows/daily_deps_test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
strategy:
1515
fail-fast: false
1616
matrix:
17-
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
17+
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
1818
pydantic-version: ['main']
1919
include:
2020
- python-version: '3.12'

pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,8 @@ dev = [
101101
"pytest >= 8.3.4",
102102
"pytest-django >= 4.6.0",
103103
"pytest-pretty >= 1.2.0",
104-
"pydantic @ git+https://github.com/pydantic/pydantic",
104+
"pydantic @ git+https://github.com/pydantic/pydantic ; python_version >= '3.9'",
105+
"pydantic==2.10.5; python_version < '3.9'",
105106
"requests >= 2.31.0",
106107
"sqlalchemy >= 1.4.54",
107108
"pandas>=2.1.2; python_version >= '3.9'",

uv.lock

Lines changed: 48 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)