Remove warning about attribute/variable name conflicts in f-string magic (#418)

Author: alexmojaki

logfire/_internal/formatter.py

@@ -169,25 +169,7 @@ def _fstring_chunks(
         # We have an f-string AST node.
         # Now prepare the namespaces that we will use to evaluate the components.
         global_vars = frame.f_globals
-        local_vars = {**frame.f_locals}
-        # Add any values in kwargs (i.e. attributes) to `local_vars` so that they take precedence.
-        # Warn the user if there's a conflict.
-        for kwarg_name, kwarg_value in kwargs.items():
-            # Check the same namespaces that Python uses, in the same order.
-            for namespace in (local_vars, global_vars, frame.f_builtins):
-                if kwarg_name in namespace:
-                    # No need to warn if they just passed the same value as an attribute, e.g. `foo=foo`.
-                    if namespace[kwarg_name] is not kwarg_value:
-                        warnings.warn(
-                            f'The attribute {kwarg_name!r} has the same name as a variable with a different value. '
-                            f'Using the attribute.',
-                            stacklevel=get_stacklevel(frame),
-                        )
-                    # No need to check the other namespaces either way,
-                    # since the earlier namespaces take precedence even in normal variable lookups.
-                    break
-            # Set the attribute value regardless of whether it's also an existing variable.
-            local_vars[kwarg_name] = kwarg_value
+        local_vars = {**frame.f_locals, **kwargs}
 
         # Now for the actual formatting!
         result: list[LiteralChunk | ArgChunk] = []

tests/test_logfire.py

@@ -1789,15 +1789,8 @@ def foo():
         with logfire.span(f'span {GLOBAL_VAR} {local_var}'), logfire.span(f'span2 {local_var}'):
             str(logfire.info(f'log {GLOBAL_VAR} {local_var}'))
 
-        with pytest.warns(UserWarning) as warnings:
-            logfire.info(f'log2 {local_var}', local_var=3, x=x)
-        assert str(warnings[0].message) == snapshot(
-            "The attribute 'local_var' has the same name as a variable with a different value. Using the attribute."
-        )
-        assert warnings[0].filename == __file__
-        frame = inspect.currentframe()
-        assert frame is not None
-        assert warnings[0].lineno == frame.f_lineno - 7
+        # Test that an attribute overrides a local variable
+        logfire.info(f'log2 {local_var}', local_var=3, x=x)
 
         # Test the .log method which has the argument in a different place from the other methods.
         logfire.log('error', f'log3 {GLOBAL_VAR}')