Reraise internal errors in tests (#328)

Author: alexmojaki

logfire/_internal/formatter.py

@@ -202,8 +202,7 @@ def _fstring_chunks(
         for node_value in arg_node.values:
             if isinstance(node_value, ast.Constant):
                 # These are the parts of the f-string not enclosed by `{}`, e.g. 'foo ' in f'foo {bar}'
-                value = node_value.value
-                assert type(value) is str
+                value: str = node_value.value
                 result.append({'v': value, 't': 'lit'})
                 new_template += value
             else:

logfire/_internal/utils.py

@@ -2,6 +2,7 @@
 
 import json
 import logging
+import os
 import sys
 from contextlib import contextmanager
 from pathlib import Path
@@ -226,6 +227,16 @@ def suppress_instrumentation():
 
 
 def log_internal_error():
+    try:
+        # Unless we're specifically testing this function, we should reraise the exception
+        # in tests for easier debugging.
+        current_test = os.environ.get('PYTEST_CURRENT_TEST', '')
+        reraise = bool(current_test and 'test_internal_exception' not in current_test)
+    except Exception:  # pragma: no cover
+        reraise = False
+    if reraise:
+        raise
+
     with suppress_instrumentation():  # prevent infinite recursion from the logging integration
         logger.exception('Internal error in Logfire')
 

tests/test_utils.py

@@ -2,7 +2,7 @@
 import requests
 import requests_mock
 
-from logfire._internal.utils import UnexpectedResponse
+from logfire._internal.utils import UnexpectedResponse, handle_internal_errors
 
 
 def test_raise_for_status() -> None:
@@ -15,3 +15,9 @@ def test_raise_for_status() -> None:
     s = str(exc_info.value)
     assert s.startswith('Unexpected response 503')
     assert 'body: this is the body' in s
+
+
+def test_reraise_internal_exception():
+    with pytest.raises(ZeroDivisionError):
+        with handle_internal_errors():
+            str(1 / 0)