Skip to content

Commit 964f585

Browse files
authored
Use new endpoint for project creation (#1202)
1 parent f4e4129 commit 964f585

File tree

3 files changed

+20
-16
lines changed

3 files changed

+20
-16
lines changed

logfire/_internal/config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1624,7 +1624,7 @@ def create_new_project(
16241624
default=project_name_default,
16251625
)
16261626

1627-
url = urljoin(logfire_api_url, f'/v1/projects/{organization}')
1627+
url = urljoin(logfire_api_url, f'/v1/organizations/{organization}/projects')
16281628
try:
16291629
response = session.post(url, headers=headers, json={'project_name': project_name})
16301630
if response.status_code == 409:

tests/test_cli.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,7 @@ def test_projects_new_with_project_name_and_org(
521521
}
522522
}
523523
m.post(
524-
'https://logfire-us.pydantic.dev/v1/projects/fake_org',
524+
'https://logfire-us.pydantic.dev/v1/organizations/fake_org/projects',
525525
[create_project_response],
526526
)
527527

@@ -562,7 +562,7 @@ def test_projects_new_with_project_name_without_org(
562562
}
563563
}
564564
m.post(
565-
'https://logfire-us.pydantic.dev/v1/projects/fake_org',
565+
'https://logfire-us.pydantic.dev/v1/organizations/fake_org/projects',
566566
[create_project_response],
567567
)
568568

@@ -605,7 +605,7 @@ def test_projects_new_with_project_name_and_wrong_org(
605605
}
606606
}
607607
m.post(
608-
'https://logfire-us.pydantic.dev/v1/projects/fake_org',
608+
'https://logfire-us.pydantic.dev/v1/organizations/fake_org/projects',
609609
[create_project_response],
610610
)
611611

@@ -646,7 +646,7 @@ def test_projects_new_with_project_name_and_default_org(
646646
}
647647
}
648648
m.post(
649-
'https://logfire-us.pydantic.dev/v1/projects/fake_org',
649+
'https://logfire-us.pydantic.dev/v1/organizations/fake_org/projects',
650650
[create_project_response],
651651
)
652652

@@ -693,7 +693,7 @@ def test_projects_new_with_project_name_multiple_organizations(
693693
}
694694
}
695695
m.post(
696-
'https://logfire-us.pydantic.dev/v1/projects/fake_org',
696+
'https://logfire-us.pydantic.dev/v1/organizations/fake_org/projects',
697697
[create_project_response],
698698
)
699699

@@ -747,7 +747,7 @@ def test_projects_new_with_project_name_and_default_org_multiple_organizations(
747747
}
748748
}
749749
m.post(
750-
'https://logfire-us.pydantic.dev/v1/projects/fake_default_org',
750+
'https://logfire-us.pydantic.dev/v1/organizations/fake_default_org/projects',
751751
[create_project_response],
752752
)
753753

@@ -786,7 +786,7 @@ def test_projects_new_without_project_name(
786786
}
787787
}
788788
m.post(
789-
'https://logfire-us.pydantic.dev/v1/projects/fake_org',
789+
'https://logfire-us.pydantic.dev/v1/organizations/fake_org/projects',
790790
[create_project_response],
791791
)
792792

@@ -829,7 +829,7 @@ def test_projects_new_invalid_project_name(
829829
}
830830
}
831831
m.post(
832-
'https://logfire-us.pydantic.dev/v1/projects/fake_org',
832+
'https://logfire-us.pydantic.dev/v1/organizations/fake_org/projects',
833833
[create_project_response],
834834
)
835835

@@ -877,7 +877,7 @@ def test_projects_new_error(tmp_dir_cwd: Path, default_credentials: Path) -> Non
877877
}
878878
}
879879
m.post(
880-
'https://logfire-us.pydantic.dev/v1/projects/fake_org',
880+
'https://logfire-us.pydantic.dev/v1/organizations/fake_org/projects',
881881
[create_project_response],
882882
)
883883

@@ -910,7 +910,7 @@ def test_projects_without_project_name_without_org(
910910
}
911911
}
912912
m.post(
913-
'https://logfire-us.pydantic.dev/v1/projects/fake_org',
913+
'https://logfire-us.pydantic.dev/v1/organizations/fake_org/projects',
914914
[create_project_response],
915915
)
916916

@@ -985,7 +985,7 @@ def test_projects_new_create_project_error(tmp_dir_cwd: Path, default_credential
985985
stack.enter_context(m)
986986
m.get('https://logfire-us.pydantic.dev/v1/projects/', json=[])
987987
m.get('https://logfire-us.pydantic.dev/v1/organizations/', json=[{'organization_name': 'fake_org'}])
988-
m.post('https://logfire-us.pydantic.dev/v1/projects/fake_org', text='Error', status_code=500)
988+
m.post('https://logfire-us.pydantic.dev/v1/organizations/fake_org/projects', text='Error', status_code=500)
989989

990990
with pytest.raises(LogfireConfigError, match='Error creating new project.'):
991991
main(['projects', 'new', 'myproject', '--org', 'fake_org'])

tests/test_configure.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -925,7 +925,9 @@ def test_initialize_project_use_existing_project_no_projects(tmp_dir_cwd: Path,
925925
'project_url': 'fake_project_url',
926926
}
927927
}
928-
request_mocker.post('https://logfire-api.pydantic.dev/v1/projects/fake_org', [create_project_response])
928+
request_mocker.post(
929+
'https://logfire-api.pydantic.dev/v1/organizations/fake_org/projects', [create_project_response]
930+
)
929931

930932
logfire.configure(send_to_logfire=True)
931933
wait_for_check_token_thread()
@@ -1023,7 +1025,9 @@ def test_initialize_project_not_using_existing_project(
10231025
'project_url': 'fake_project_url',
10241026
}
10251027
}
1026-
request_mocker.post('https://logfire-api.pydantic.dev/v1/projects/fake_org', [create_project_response])
1028+
request_mocker.post(
1029+
'https://logfire-api.pydantic.dev/v1/organizations/fake_org/projects', [create_project_response]
1030+
)
10271031
request_mocker.post(
10281032
'https://logfire-api.pydantic.dev/v1/organizations/fake_org/projects/fake_project/write-tokens/',
10291033
[create_project_response],
@@ -1145,7 +1149,7 @@ def test_initialize_project_create_project(tmp_dir_cwd: Path, tmp_path: Path, ca
11451149
}
11461150
}
11471151
request_mocker.post(
1148-
'https://logfire-api.pydantic.dev/v1/projects/fake_org',
1152+
'https://logfire-api.pydantic.dev/v1/organizations/fake_org/projects',
11491153
[
11501154
create_existing_project_response,
11511155
create_reserved_project_response,
@@ -1241,7 +1245,7 @@ def test_initialize_project_create_project_default_organization(tmp_dir_cwd: Pat
12411245
}
12421246
}
12431247
request_mocker.post(
1244-
'https://logfire-api.pydantic.dev/v1/projects/fake_org',
1248+
'https://logfire-api.pydantic.dev/v1/organizations/fake_org/projects',
12451249
[create_project_response],
12461250
)
12471251

0 commit comments

Comments
 (0)