Handle wrong JSON schema in console exporter (#1294)

Co-authored-by: sbhrwlr <[email protected]>
Co-authored-by: Rahul Sabharwal <[email protected]>

Author: alexmojaki

logfire/_internal/json_formatter.py

@@ -68,9 +68,9 @@ def _format(
         if schema is not None:
             if 'type' in schema:
                 if (data_type := schema.get('x-python-datatype')) is None:
-                    if schema['type'] == 'object':
+                    if schema['type'] == 'object' and isinstance(value, dict):
                         self._format_items('{', ': ', '}', True, indent_current, value, None)
-                    elif schema['type'] == 'array':
+                    elif schema['type'] == 'array' and isinstance(value, list):
                         self._format_list_like('[', ']', indent_current, value, schema)
                     else:
                         # e.g. {'type': 'string', 'format': 'date-time'}

tests/test_console_exporter.py

@@ -4,6 +4,8 @@
 import decimal
 import enum
 import io
+import json
+import re
 import sys
 from datetime import datetime
 from typing import Any
@@ -17,6 +19,7 @@
 from opentelemetry._logs import SeverityNumber, get_logger
 from opentelemetry.sdk._logs import LogRecord
 from opentelemetry.sdk.trace import ReadableSpan
+from opentelemetry.trace import get_tracer
 from opentelemetry.version import __version__ as otel_version
 
 import logfire
@@ -993,6 +996,7 @@ class MyIntEnum(int, enum.Enum):
         e=MyEnum.ABC,
         se=MyStrEnum.STR,
         ie=MyIntEnum.INT,
+        rp=re.compile(r'^[\w\.-]+@[\w\.-]+\.\w+$'),
     )
 
     assert capsys.readouterr().out.splitlines() == snapshot(
@@ -1005,5 +1009,39 @@ class MyIntEnum(int, enum.Enum):
             "│ e=MyEnum('abc')",
             "│ se=MyStrEnum('str_val')",
             '│ ie=MyIntEnum(1)',
+            '│ rp=^[\\w\\.-]+@[\\w\\.-]+\\.\\w+$',
+        ]
+    )
+
+
+def test_console_exporter_list_data_with_object_schema_mismatch(capsys: pytest.CaptureFixture[str]) -> None:
+    logfire.configure(
+        send_to_logfire=False,
+        console=ConsoleOptions(verbose=True, colors='never', include_timestamps=False),
+    )
+
+    get_tracer(__name__).start_span(
+        'test_span',
+        attributes={
+            'foo': json.dumps(['item1', 'item2', 'item3']),
+            'bar': json.dumps({'name': 'Alice', 'age': 30}),
+            'logfire.json_schema': json.dumps(
+                {
+                    'type': 'object',
+                    'properties': {
+                        # These are wrong
+                        'foo': {'type': 'object'},
+                        'bar': {'type': 'array'},
+                    },
+                }
+            ),
+        },
+    ).end()
+
+    assert capsys.readouterr().out.splitlines() == snapshot(
+        [
+            'test_span',
+            "│ foo=['item1', 'item2', 'item3']",
+            "│ bar={'name': 'Alice', 'age': 30}",
         ]
     )