Skip to content

Commit c57abc0

Browse files
authored
Upgrade pyright, fix private imports (#964)
1 parent b2f41b7 commit c57abc0

21 files changed

+60
-52
lines changed

logfire/_internal/config.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,17 @@
1919

2020
import requests
2121
from opentelemetry import trace
22-
from opentelemetry._logs import NoOpLoggerProvider, set_logger_provider
22+
from opentelemetry._logs import NoOpLoggerProvider, set_logger_provider # type: ignore
2323
from opentelemetry.environment_variables import OTEL_LOGS_EXPORTER, OTEL_METRICS_EXPORTER, OTEL_TRACES_EXPORTER
2424
from opentelemetry.exporter.otlp.proto.http import Compression
25-
from opentelemetry.exporter.otlp.proto.http._log_exporter import OTLPLogExporter
25+
from opentelemetry.exporter.otlp.proto.http._log_exporter import OTLPLogExporter # type: ignore
2626
from opentelemetry.exporter.otlp.proto.http.metric_exporter import OTLPMetricExporter
2727
from opentelemetry.exporter.otlp.proto.http.trace_exporter import OTLPSpanExporter
2828
from opentelemetry.metrics import NoOpMeterProvider, set_meter_provider
2929
from opentelemetry.propagate import get_global_textmap, set_global_textmap
30-
from opentelemetry.sdk._logs import LoggerProvider as SDKLoggerProvider, LogRecordProcessor
31-
from opentelemetry.sdk._logs._internal import SynchronousMultiLogRecordProcessor
32-
from opentelemetry.sdk._logs.export import BatchLogRecordProcessor, SimpleLogRecordProcessor
30+
from opentelemetry.sdk._logs import LoggerProvider as SDKLoggerProvider, LogRecordProcessor # type: ignore
31+
from opentelemetry.sdk._logs._internal import SynchronousMultiLogRecordProcessor # type: ignore
32+
from opentelemetry.sdk._logs.export import BatchLogRecordProcessor, SimpleLogRecordProcessor # type: ignore
3333
from opentelemetry.sdk.environment_variables import (
3434
OTEL_BSP_SCHEDULE_DELAY,
3535
OTEL_EXPORTER_OTLP_ENDPOINT,
@@ -106,7 +106,7 @@
106106
)
107107

108108
if TYPE_CHECKING:
109-
from opentelemetry._events import EventLoggerProvider
109+
from opentelemetry._events import EventLoggerProvider # type: ignore
110110

111111
from .main import Logfire
112112

@@ -703,7 +703,7 @@ def __init__(
703703
self._meter_provider = ProxyMeterProvider(NoOpMeterProvider())
704704
self._logger_provider = ProxyLoggerProvider(NoOpLoggerProvider())
705705
try:
706-
from opentelemetry.sdk._events import EventLoggerProvider as SDKEventLoggerProvider
706+
from opentelemetry.sdk._events import EventLoggerProvider as SDKEventLoggerProvider # type: ignore
707707

708708
self._event_logger_provider = SDKEventLoggerProvider(self._logger_provider) # type: ignore
709709
except ImportError:
@@ -1066,7 +1066,7 @@ def fix_pid(): # pragma: no cover
10661066
set_meter_provider(self._meter_provider)
10671067
set_logger_provider(self._logger_provider)
10681068
if self._event_logger_provider:
1069-
from opentelemetry._events import set_event_logger_provider
1069+
from opentelemetry._events import set_event_logger_provider # type: ignore
10701070

10711071
set_event_logger_provider(self._event_logger_provider)
10721072

logfire/_internal/exporters/console.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
from textwrap import indent as indent_text
1515
from typing import Any, List, Literal, Mapping, TextIO, Tuple, cast
1616

17-
from opentelemetry.sdk._logs import LogData, LogRecord
18-
from opentelemetry.sdk._logs.export import LogExporter, LogExportResult
17+
from opentelemetry.sdk._logs import LogData, LogRecord # type: ignore
18+
from opentelemetry.sdk._logs.export import LogExporter, LogExportResult # type: ignore
1919
from opentelemetry.sdk.trace import Event, ReadableSpan
2020
from opentelemetry.sdk.trace.export import SpanExporter, SpanExportResult
2121
from opentelemetry.util import types as otel_types

logfire/_internal/exporters/logs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from dataclasses import dataclass
22

3-
from opentelemetry.sdk._logs import LogData
3+
from opentelemetry.sdk._logs import LogData # type: ignore
44

55
import logfire
66
from logfire._internal.exporters.wrapper import WrapperLogProcessor

logfire/_internal/exporters/otlp.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
from typing import Any, Mapping, Sequence
1313

1414
import requests.exceptions
15-
from opentelemetry.sdk._logs import LogData
16-
from opentelemetry.sdk._logs._internal.export import LogExportResult
15+
from opentelemetry.sdk._logs import LogData # type: ignore
16+
from opentelemetry.sdk._logs._internal.export import LogExportResult # type: ignore
1717
from opentelemetry.sdk.trace import ReadableSpan
1818
from opentelemetry.sdk.trace.export import SpanExportResult
1919
from requests import Session

logfire/_internal/exporters/processor_wrapper.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ def _tweak_http_spans(span: ReadableSpanDict):
194194
method = attributes.get(SpanAttributes.HTTP_METHOD)
195195
route = attributes.get(SpanAttributes.HTTP_ROUTE)
196196
target = attributes.get(SpanAttributes.HTTP_TARGET)
197-
url = attributes.get(SpanAttributes.HTTP_URL)
197+
url: Any = attributes.get(SpanAttributes.HTTP_URL)
198198
if not (method or route or target or url):
199199
return
200200

@@ -225,7 +225,7 @@ def _tweak_http_spans(span: ReadableSpanDict):
225225
)
226226
if not server_name:
227227
try:
228-
server_name = urlparse(url).hostname # type: ignore
228+
server_name = urlparse(url).hostname
229229
except Exception: # pragma: no cover
230230
pass
231231
server_name = server_name or url

logfire/_internal/exporters/quiet_metrics.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
from typing import Any
22

33
import requests
4-
from opentelemetry.sdk.metrics._internal.export import MetricExportResult
5-
from opentelemetry.sdk.metrics._internal.point import MetricsData
4+
from opentelemetry.sdk.metrics.export import MetricExportResult, MetricsData
65

76
from .wrapper import WrapperMetricExporter
87

logfire/_internal/exporters/test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
from typing import Any, Mapping, cast
1313

1414
from opentelemetry import trace
15-
from opentelemetry.sdk._logs import LogData
16-
from opentelemetry.sdk._logs._internal.export import LogExportResult
17-
from opentelemetry.sdk._logs.export import InMemoryLogExporter
15+
from opentelemetry.sdk._logs import LogData # type: ignore
16+
from opentelemetry.sdk._logs._internal.export import LogExportResult # type: ignore
17+
from opentelemetry.sdk._logs.export import InMemoryLogExporter # type: ignore
1818
from opentelemetry.sdk.trace import Event, ReadableSpan
1919
from opentelemetry.sdk.trace.export import SpanExporter, SpanExportResult
2020
from opentelemetry.semconv.resource import ResourceAttributes

logfire/_internal/exporters/wrapper.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
from typing import Any, Sequence, cast
55

66
from opentelemetry import context
7-
from opentelemetry.sdk._logs import LogData, LogRecordProcessor
8-
from opentelemetry.sdk._logs.export import LogExporter, LogExportResult
7+
from opentelemetry.sdk._logs import LogData, LogRecordProcessor # type: ignore
8+
from opentelemetry.sdk._logs.export import LogExporter, LogExportResult # type: ignore
99
from opentelemetry.sdk.metrics.export import AggregationTemporality, MetricExporter, MetricExportResult, MetricsData
1010
from opentelemetry.sdk.metrics.view import Aggregation
1111
from opentelemetry.sdk.trace import ReadableSpan, Span, SpanProcessor

logfire/_internal/integrations/llm_providers/openai.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ def get_response_data(self) -> Any:
108108

109109
try:
110110
# ChatCompletionStreamState only exists in openai>=1.40.0
111-
from openai.lib.streaming.chat._completions import ChatCompletionStreamState
111+
from openai.lib.streaming.chat._completions import ChatCompletionStreamState # type: ignore
112112

113113
class OpenaiChatCompletionStreamState(StreamState):
114114
def __init__(self):

logfire/_internal/logs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from typing import Any
88
from weakref import WeakSet
99

10-
from opentelemetry._logs import Logger, LoggerProvider, LogRecord, NoOpLoggerProvider
10+
from opentelemetry._logs import Logger, LoggerProvider, LogRecord, NoOpLoggerProvider # type: ignore
1111
from opentelemetry.util.types import Attributes
1212

1313

0 commit comments

Comments
 (0)