Remove TypeAlias from code source (#359)

Author: Kludex

logfire-api/logfire_api/_internal/main.pyi

@@ -1,7 +1,6 @@
 import anthropic
 import openai
 import opentelemetry.trace as trace_api
-import typing
 from . import async_ as async_
 from ..version import VERSION as VERSION
 from .auto_trace import AutoTraceModule as AutoTraceModule, install_auto_tracing as install_auto_tracing
@@ -38,7 +37,7 @@ from starlette.websockets import WebSocket as WebSocket
 from typing import Any, Callable, ContextManager, Iterable, Literal, Sequence, TypeVar
 from typing_extensions import LiteralString, Unpack
 
-ExcInfo: typing.TypeAlias
+ExcInfo = SysExcInfo | BaseException | bool | None
 
 class Logfire:
     """The main logfire class."""

logfire-api/logfire_api/_internal/utils.pyi

@@ -1,4 +1,3 @@
-import typing
 from _typeshed import Incomplete
 from collections.abc import Generator
 from logfire._internal.stack_info import is_user_code as is_user_code
@@ -11,8 +10,10 @@ from opentelemetry.util import types as otel_types
 from packaging.version import Version
 from pathlib import Path
 from requests import RequestException, Response
+from types import TracebackType
 from typing import Any, Mapping, Sequence, TypeVar, TypedDict
 
+SysExcInfo = tuple[type[BaseException], BaseException, TracebackType | None] | tuple[None, None, None]
 T = TypeVar('T')
 JsonValue: Incomplete
 JsonDict = dict[str, JsonValue]
@@ -84,8 +85,5 @@ def is_instrumentation_suppressed() -> bool:
 def suppress_instrumentation() -> Generator[None, None, None]:
     """Context manager to suppress all logs/spans generated by logfire or OpenTelemetry."""
 def log_internal_error() -> None: ...
-
-SysExcInfo: typing.TypeAlias
-
 def handle_internal_errors() -> Generator[None, None, None]: ...
 def maybe_capture_server_headers(capture: bool): ...

logfire/_internal/main.py

@@ -4,7 +4,6 @@
 import inspect
 import sys
 import traceback
-import typing
 import warnings
 from functools import cached_property, partial
 from time import time
@@ -51,7 +50,7 @@
 from .metrics import ProxyMeterProvider
 from .stack_info import get_user_stack_info
 from .tracer import ProxyTracerProvider
-from .utils import SysExcInfo, handle_internal_errors, log_internal_error, uniquify_sequence
+from .utils import handle_internal_errors, log_internal_error, uniquify_sequence
 
 if TYPE_CHECKING:
     import anthropic
@@ -75,20 +74,21 @@
     from .integrations.redis import RedisInstrumentKwargs
     from .integrations.sqlalchemy import SQLAlchemyInstrumentKwargs
     from .integrations.starlette import StarletteInstrumentKwargs
+    from .utils import SysExcInfo
+
+    # This is the type of the exc_info/_exc_info parameter of the log methods.
+    # sys.exc_info() returns a tuple of (type, value, traceback) or (None, None, None).
+    # We just need the exception, but we allow the user to pass the tuple because:
+    # 1. It's convenient to pass the result of sys.exc_info() directly
+    # 2. It mirrors the exc_info argument of the stdlib logging methods
+    # 3. The argument name exc_info is very suggestive of the sys function.
+    ExcInfo = Union[SysExcInfo, BaseException, bool, None]
 
 try:
     from pydantic import ValidationError
 except ImportError:  # pragma: no cover
     ValidationError = None
 
-# This is the type of the exc_info/_exc_info parameter of the log methods.
-# sys.exc_info() returns a tuple of (type, value, traceback) or (None, None, None).
-# We just need the exception, but we allow the user to pass the tuple because:
-# 1. It's convenient to pass the result of sys.exc_info() directly
-# 2. It mirrors the exc_info argument of the stdlib logging methods
-# 3. The argument name exc_info is very suggestive of the sys function.
-ExcInfo: typing.TypeAlias = Union[SysExcInfo, BaseException, bool, None]
-
 
 class Logfire:
     """The main logfire class."""

logfire/_internal/utils.py

@@ -5,7 +5,6 @@
 import logging
 import os
 import sys
-import typing
 from contextlib import contextmanager
 from pathlib import Path
 from types import TracebackType
@@ -24,6 +23,11 @@
 if TYPE_CHECKING:
     from packaging.version import Version
 
+    SysExcInfo = Union[tuple[type[BaseException], BaseException, TracebackType | None], tuple[None, None, None]]
+    """
+    The return type of sys.exc_info(): exc_type, exc_val, exc_tb.
+    """
+
 T = TypeVar('T')
 
 JsonValue = Union[int, float, str, bool, None, List['JsonValue'], Tuple['JsonValue', ...], 'JsonDict']
@@ -260,15 +264,6 @@ def log_internal_error():
         logger.exception('Internal error in Logfire', exc_info=_internal_error_exc_info())
 
 
-SysExcInfo: typing.TypeAlias = Union[
-    'tuple[type[BaseException], BaseException, TracebackType | None]',
-    'tuple[None, None, None]',
-]
-"""
-The return type of sys.exc_info(): exc_type, exc_val, exc_tb.
-"""
-
-
 def _internal_error_exc_info() -> SysExcInfo:
     """Returns an exc_info tuple with a nicely tweaked traceback."""
     original_exc_info: SysExcInfo = sys.exc_info()