Switch UpDownCounters to cumulative aggregation temporality (#347)

Author: alexmojaki

logfire/_internal/config.py

@@ -88,11 +88,11 @@
 
 METRICS_PREFERRED_TEMPORALITY = {
     Counter: AggregationTemporality.DELTA,
-    UpDownCounter: AggregationTemporality.DELTA,
+    UpDownCounter: AggregationTemporality.CUMULATIVE,
     Histogram: AggregationTemporality.DELTA,
     ObservableCounter: AggregationTemporality.DELTA,
-    ObservableUpDownCounter: AggregationTemporality.DELTA,
-    ObservableGauge: AggregationTemporality.DELTA,
+    ObservableUpDownCounter: AggregationTemporality.CUMULATIVE,
+    ObservableGauge: AggregationTemporality.CUMULATIVE,
 }
 """This should be passed as the `preferred_temporality` argument of metric readers and exporters."""
 

tests/otel_integrations/test_django.py

@@ -46,7 +46,7 @@ def test_good_route(client: Client, exporter: TestExporter, metrics_reader: InMe
                             'value': 0,
                         }
                     ],
-                    'aggregation_temporality': 1,
+                    'aggregation_temporality': 2,
                     'is_monotonic': False,
                 },
             },

tests/test_metrics.py

@@ -211,10 +211,10 @@ def test_create_metric_up_down_counter(metrics_reader: InMemoryMetricReader) ->
                             'attributes': {},
                             'start_time_unix_nano': IsInt(),
                             'time_unix_nano': IsInt(),
-                            'value': 4300,
+                            'value': 4321,
                         }
                     ],
-                    'aggregation_temporality': AggregationTemporality.DELTA,
+                    'aggregation_temporality': AggregationTemporality.CUMULATIVE,
                     'is_monotonic': False,
                 },
             }
@@ -313,10 +313,10 @@ def observable_counter(options: CallbackOptions):
                             'attributes': {},
                             'start_time_unix_nano': IsInt(),
                             'time_unix_nano': IsInt(),
-                            'value': 4300,
+                            'value': 4321,
                         }
                     ],
-                    'aggregation_temporality': AggregationTemporality.DELTA,
+                    'aggregation_temporality': AggregationTemporality.CUMULATIVE,
                     'is_monotonic': False,
                 },
             }