Skip to content

feat: access spans created by instrument decorator #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: access spans created by instrument decorator #1419

wants to merge 3 commits into from

Conversation

oliviaBahr
Copy link

I find myself often wanting to interact with spans created by the instrument decorator.

I've done two implementations: one adding an optional param to the decorator, the other using a context var on the logfire instance.
I prefer the context var impl because the usage is nicer but I'm not sure about the overhead.

@codecov Codecov
Copy link

codecov bot commented Sep 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@alexmojaki
Copy link
Contributor

  1. A function called logfire.current_span() can't just work for instrument, it at least needs to work for logfire.span, it should probably return something useful for all OTel spans. We've wanted to implement a function like this, with this name, for a while but haven't had time. It would wrap arbitrary spans while allowing things like setting complex attributes.
  2. This absolutely can't depend on whether logfire.current_span appears somewhere in the body of the decorated function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviaBahr @alexmojaki