Skip to content

Commit 6b06581

Browse files
committed
feedback: None default for the val ctx and require kwargs after data in process functions
1 parent bff548e commit 6b06581

File tree

2 files changed

+27
-11
lines changed

2 files changed

+27
-11
lines changed

pydantic_ai_slim/pydantic_ai/_output.py

Lines changed: 22 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -529,8 +529,9 @@ class BaseOutputProcessor(ABC, Generic[OutputDataT]):
529529
async def process(
530530
self,
531531
data: str,
532+
*,
532533
run_context: RunContext[AgentDepsT],
533-
validation_context: Any | None,
534+
validation_context: Any | None = None,
534535
allow_partial: bool = False,
535536
wrap_validation_errors: bool = True,
536537
) -> OutputDataT:
@@ -554,17 +555,18 @@ def __init__(self, wrapped: BaseObjectOutputProcessor[OutputDataT]):
554555
async def process(
555556
self,
556557
data: str,
558+
*,
557559
run_context: RunContext[AgentDepsT],
558-
validation_context: Any | None,
560+
validation_context: Any | None = None,
559561
allow_partial: bool = False,
560562
wrap_validation_errors: bool = True,
561563
) -> OutputDataT:
562564
text = _utils.strip_markdown_fences(data)
563565

564566
return await self.wrapped.process(
565567
text,
566-
run_context,
567-
validation_context,
568+
run_context=run_context,
569+
validation_context=validation_context,
568570
allow_partial=allow_partial,
569571
wrap_validation_errors=wrap_validation_errors,
570572
)
@@ -644,8 +646,9 @@ def __init__(
644646
async def process(
645647
self,
646648
data: str | dict[str, Any] | None,
649+
*,
647650
run_context: RunContext[AgentDepsT],
648-
validation_context: Any | None,
651+
validation_context: Any | None = None,
649652
allow_partial: bool = False,
650653
wrap_validation_errors: bool = True,
651654
) -> OutputDataT:
@@ -809,15 +812,16 @@ def __init__(
809812
async def process(
810813
self,
811814
data: str,
815+
*,
812816
run_context: RunContext[AgentDepsT],
813817
validation_context: Any | None = None,
814818
allow_partial: bool = False,
815819
wrap_validation_errors: bool = True,
816820
) -> OutputDataT:
817821
union_object = await self._union_processor.process(
818822
data,
819-
run_context,
820-
validation_context,
823+
run_context=run_context,
824+
validation_context=validation_context,
821825
allow_partial=allow_partial,
822826
wrap_validation_errors=wrap_validation_errors,
823827
)
@@ -836,8 +840,8 @@ async def process(
836840

837841
return await processor.process(
838842
inner_data,
839-
run_context,
840-
validation_context,
843+
run_context=run_context,
844+
validation_context=validation_context,
841845
allow_partial=allow_partial,
842846
wrap_validation_errors=wrap_validation_errors,
843847
)
@@ -847,6 +851,7 @@ class TextOutputProcessor(BaseOutputProcessor[OutputDataT]):
847851
async def process(
848852
self,
849853
data: str,
854+
*,
850855
run_context: RunContext[AgentDepsT],
851856
validation_context: Any | None = None,
852857
allow_partial: bool = False,
@@ -879,6 +884,7 @@ def __init__(
879884
async def process(
880885
self,
881886
data: str,
887+
*,
882888
run_context: RunContext[AgentDepsT],
883889
validation_context: Any | None = None,
884890
allow_partial: bool = False,
@@ -887,7 +893,13 @@ async def process(
887893
args = {self._str_argument_name: data}
888894
data = await execute_traced_output_function(self._function_schema, run_context, args, wrap_validation_errors)
889895

890-
return await super().process(data, run_context, validation_context, allow_partial, wrap_validation_errors)
896+
return await super().process(
897+
data,
898+
run_context=run_context,
899+
validation_context=validation_context,
900+
allow_partial=allow_partial,
901+
wrap_validation_errors=wrap_validation_errors,
902+
)
891903

892904

893905
@dataclass(init=False)

pydantic_ai_slim/pydantic_ai/result.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,11 @@ async def validate_response_output(
200200
validation_context = build_validation_context(self._tool_manager.validation_ctx, self._run_ctx)
201201

202202
result_data = await text_processor.process(
203-
text, self._run_ctx, validation_context, allow_partial=allow_partial, wrap_validation_errors=False
203+
text,
204+
run_context=self._run_ctx,
205+
validation_context=validation_context,
206+
allow_partial=allow_partial,
207+
wrap_validation_errors=False,
204208
)
205209
for validator in self._output_validators:
206210
result_data = await validator.validate(

0 commit comments

Comments
 (0)