Skip to content

Commit 8335128

Browse files
committed
remove further type check
1 parent bb4d9c3 commit 8335128

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
1-
from typing import Any
1+
from typing import TYPE_CHECKING
22

33
from outlines.models.base import Model
44

5+
if TYPE_CHECKING:
6+
from vllm import LLM
7+
58
class VLLMOffline(Model): ...
69

7-
def from_vllm_offline(model: Any) -> VLLMOffline: ...
10+
def from_vllm_offline(model: LLM) -> VLLMOffline: ...

tests/models/test_outlines.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -179,9 +179,7 @@ def sglang_model() -> OutlinesModel:
179179

180180
@pytest.fixture
181181
def vllm_model_offline() -> OutlinesModel: # pragma: no cover
182-
outlines_model = outlines.models.vllm_offline.from_vllm_offline( # type: ignore
183-
vllm.LLM('microsoft/Phi-3-mini-4k-instruct') # type: ignore
184-
)
182+
outlines_model = outlines.models.vllm_offline.from_vllm_offline(vllm.LLM('microsoft/Phi-3-mini-4k-instruct'))
185183
return OutlinesModel(outlines_model, provider=OutlinesProvider())
186184

187185

@@ -226,7 +224,7 @@ def binary_image() -> BinaryImage:
226224
),
227225
pytest.param(
228226
'from_vllm_offline',
229-
lambda: (vllm.LLM('microsoft/Phi-3-mini-4k-instruct'),), # type: ignore
227+
lambda: (vllm.LLM('microsoft/Phi-3-mini-4k-instruct'),),
230228
marks=skip_if_vllm_imports_unsuccessful,
231229
),
232230
]
@@ -285,7 +283,7 @@ def test_init(model_loading_function_name: str, args: Callable[[], tuple[Any]])
285283
),
286284
pytest.param(
287285
'from_vllm_offline',
288-
lambda: (vllm.LLM('microsoft/Phi-3-mini-4k-instruct'),), # type: ignore
286+
lambda: (vllm.LLM('microsoft/Phi-3-mini-4k-instruct'),),
289287
marks=skip_if_vllm_imports_unsuccessful,
290288
),
291289
]

0 commit comments

Comments
 (0)