lift vendor part id restriction for embedded thinking - checking for coverage

Author: dsfaccini

pydantic_ai_slim/pydantic_ai/_parts_manager.py

@@ -29,3 +29,8 @@ def split_content_into_text_and_thinking(content: str, thinking_tags: tuple[str,
     if content:
         parts.append(TextPart(content=content))
     return parts
+
+
+# NOTE: this utility is used by models/: `groq`, `huggingface`, `openai`, `outlines` and `tests/test_thinking_part.py`
+# not sure if it could be replaced by the new handling in the `_parts_manager.py` but it's worth taking a closer look.
+# if that's the case we could use this file to partly isolate the embedded thinking handling logic and declutter the parts manager.

pydantic_ai_slim/pydantic_ai/_thinking_part.py

@@ -640,7 +640,12 @@ async def chain_async_and_sync_iters(
                 if end_event:
                     yield end_event
 
-            self._event_iterator = iterator_with_part_end(iterator_with_final_event(self._get_event_iterator()))
+            self._event_iterator = iterator_with_part_end(
+                iterator_with_final_event(
+                    # TODO chain_async_and_sync_iters(iterator, self._parts_manager.final_flush())
+                    self._get_event_iterator()
+                )
+            )
         return self._event_iterator
 
     @abstractmethod

pydantic_ai_slim/pydantic_ai/models/__init__.py

@@ -579,6 +579,10 @@ async def _get_event_iterator(self) -> AsyncIterator[ModelResponseStreamEvent]:
                         vendor_part_id='content',
                         content=content,
                         thinking_tags=self._model_profile.thinking_tags,
+                        # where does `ignore_leading_whitespace` come from?
+                        # `GroqModel._process_streamed_response()` returns a `GroqStreamedResponse(_model_profile=self.profile,)`
+                        # `Groq.profile`` is set at `super().__init__(settings=settings, profile=profile or provider.model_profile)`
+                        # so `_model_profile` comes either from `GroqModel(profile=...)` or `GroqModel(provider=GroqProvider(...))` where the provider infers a profile.
                         ignore_leading_whitespace=self._model_profile.ignore_streamed_leading_whitespace,
                     ):
                         yield event

pydantic_ai_slim/pydantic_ai/models/groq.py

@@ -1973,7 +1973,6 @@ async def test_groq_model_thinking_part_iter(allow_model_requests: None, groq_ap
                 parts=[
                     ThinkingPart(
                         content="""\
-
 Okay, so I want to make Uruguayan alfajores. I've heard they're a type of South American cookie sandwich with dulce de leche. I'm not entirely sure about the exact steps, but I can try to figure it out based on what I know.
 
 First, I think alfajores are cookies, so I'll need to make the cookie part. From what I remember, the dough is probably made with flour, sugar, butter, eggs, vanilla, and maybe some baking powder or baking soda. I should look up a typical cookie dough recipe and adjust it for alfajores.
@@ -2061,8 +2060,7 @@ async def test_groq_model_thinking_part_iter(allow_model_requests: None, groq_ap
 
     assert event_parts == snapshot(
         [
-            PartStartEvent(index=0, part=ThinkingPart(content='\n')),
-            PartDeltaEvent(index=0, delta=ThinkingPartDelta(content_delta='Okay')),
+            PartStartEvent(index=0, part=ThinkingPart(content='Okay')),
             PartDeltaEvent(index=0, delta=ThinkingPartDelta(content_delta=',')),
             PartDeltaEvent(index=0, delta=ThinkingPartDelta(content_delta=' so')),
             PartDeltaEvent(index=0, delta=ThinkingPartDelta(content_delta=' I')),
@@ -2582,7 +2580,6 @@ async def test_groq_model_thinking_part_iter(allow_model_requests: None, groq_ap
                 index=0,
                 part=ThinkingPart(
                     content="""\
-
 Okay, so I want to make Uruguayan alfajores. I've heard they're a type of South American cookie sandwich with dulce de leche. I'm not entirely sure about the exact steps, but I can try to figure it out based on what I know.
 
 First, I think alfajores are cookies, so I'll need to make the cookie part. From what I remember, the dough is probably made with flour, sugar, butter, eggs, vanilla, and maybe some baking powder or baking soda. I should look up a typical cookie dough recipe and adjust it for alfajores.