Use message_history arg for run_chat; fix typos in tests

Author: uriyyo

pydantic_ai_slim/pydantic_ai/_cli.py

@@ -232,7 +232,7 @@ def cli(  # noqa: C901
         return 0
 
     try:
-        return asyncio.run(run_chat(stream, agent, console, code_theme, prog_name, history=history))
+        return asyncio.run(run_chat(stream, agent, console, code_theme, prog_name, message_history=history))
     except KeyboardInterrupt:  # pragma: no cover
         return 0
 

tests/test_cli.py

@@ -58,7 +58,7 @@ def _create_test_module(**namespace: Any) -> None:
 
 
 @pytest.fixture
-def emtpy_last_conversation_path():
+def empty_last_conversation_path():
     path = PYDANTIC_AI_HOME / LAST_CONVERSATION_FILENAME
 
     if path.exists():
@@ -180,32 +180,32 @@ def test_cli_continue_last_conversation(
     args: list[str],
     capfd: CaptureFixture[str],
     env: TestEnv,
-    emtpy_last_conversation_path: Path,
+    empty_last_conversation_path: Path,
 ):
     env.set('OPENAI_API_KEY', 'test')
     with cli_agent.override(model=TestModel(custom_output_text='# world')):
         assert cli(args) == 0
         assert capfd.readouterr().out.splitlines() == snapshot([IsStr(), '# world'])
-        assert emtpy_last_conversation_path.exists()
-        content = emtpy_last_conversation_path.read_text()
+        assert empty_last_conversation_path.exists()
+        content = empty_last_conversation_path.read_text()
         assert content
 
         assert cli(args) == 0
         assert capfd.readouterr().out.splitlines() == snapshot([IsStr(), '# world'])
-        assert emtpy_last_conversation_path.exists()
-        # verity that new content is appended to the file
-        assert len(emtpy_last_conversation_path.read_text()) > len(content)
+        assert empty_last_conversation_path.exists()
+        # verify that new content is appended to the file
+        assert len(empty_last_conversation_path.read_text()) > len(content)
 
 
 @pytest.mark.parametrize('args', [['hello', '-c'], ['hello', '--continue']])
 def test_cli_continue_last_conversation_corrupted_file(
     args: list[str],
     capfd: CaptureFixture[str],
     env: TestEnv,
-    emtpy_last_conversation_path: Path,
+    empty_last_conversation_path: Path,
 ):
     env.set('OPENAI_API_KEY', 'test')
-    emtpy_last_conversation_path.write_text('not a valid json')
+    empty_last_conversation_path.write_text('not a valid json')
     with cli_agent.override(model=TestModel(custom_output_text='# world')):
         assert cli(args) == 0
         assert capfd.readouterr().out.splitlines() == snapshot(
@@ -216,8 +216,8 @@ def test_cli_continue_last_conversation_corrupted_file(
                 '# world',
             ]
         )
-        assert emtpy_last_conversation_path.exists()
-        assert emtpy_last_conversation_path.read_text()
+        assert empty_last_conversation_path.exists()
+        assert empty_last_conversation_path.read_text()
 
 
 def test_chat(capfd: CaptureFixture[str], mocker: MockerFixture, env: TestEnv):
@@ -320,21 +320,42 @@ def test_code_theme_unset(mocker: MockerFixture, env: TestEnv):
     env.set('OPENAI_API_KEY', 'test')
     mock_run_chat = mocker.patch('pydantic_ai._cli.run_chat')
     cli([])
-    mock_run_chat.assert_awaited_once_with(True, IsInstance(Agent), IsInstance(Console), 'monokai', 'pai', history=None)
+    mock_run_chat.assert_awaited_once_with(
+        True,
+        IsInstance(Agent),
+        IsInstance(Console),
+        'monokai',
+        'pai',
+        message_history=None,
+    )
 
 
 def test_code_theme_light(mocker: MockerFixture, env: TestEnv):
     env.set('OPENAI_API_KEY', 'test')
     mock_run_chat = mocker.patch('pydantic_ai._cli.run_chat')
     cli(['--code-theme=light'])
-    mock_run_chat.assert_awaited_once_with(True, IsInstance(Agent), IsInstance(Console), 'default', 'pai', history=None)
+    mock_run_chat.assert_awaited_once_with(
+        True,
+        IsInstance(Agent),
+        IsInstance(Console),
+        'default',
+        'pai',
+        message_history=None,
+    )
 
 
 def test_code_theme_dark(mocker: MockerFixture, env: TestEnv):
     env.set('OPENAI_API_KEY', 'test')
     mock_run_chat = mocker.patch('pydantic_ai._cli.run_chat')
     cli(['--code-theme=dark'])
-    mock_run_chat.assert_awaited_once_with(True, IsInstance(Agent), IsInstance(Console), 'monokai', 'pai', history=None)
+    mock_run_chat.assert_awaited_once_with(
+        True,
+        IsInstance(Agent),
+        IsInstance(Console),
+        'monokai',
+        'pai',
+        message_history=None,
+    )
 
 
 def test_agent_to_cli_sync(mocker: MockerFixture, env: TestEnv):