Add ModelResponse.finish_reason and set provider_response_id while streaming
#2590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DouweM
changed the title
DouweM
requested changes
Sep 1, 2025
fatelei
force-pushed
the
issue-886
branch
2 times, most recently
from
4422cb0 to
35185ad
Compare
Contributor
Author
|
spell check in pre commit failed |
DouweM
requested changes
Sep 2, 2025
| if chunk.response.id and self.provider_response_id is None: | ||
| self.provider_response_id = chunk.response.id | ||
| if self.finish_reason is None: | ||
| incomplete_reason = getattr(getattr(chunk.response, 'incomplete_details', None), 'reason', None) |
Collaborator
There was a problem hiding this comment.
As above, why do we need getattr here?
Contributor
Author
There was a problem hiding this comment.
Using nested getattr(..., default=None) safely handles both cases without exceptions and without assuming dict access:
• getattr(chunk.response, 'incomplete_details', None) guards missing field
• getattr(..., 'reason', None) guards missing reason on that object
An alternative like (incomplete_details or {}).get('reason') won’t work reliably because incomplete_details isn’t always a dict.
fatelei
force-pushed
the
issue-886
branch
2 times, most recently
from
e81aabc to
23f12ba
Compare
DouweM
requested changes
Sep 3, 2025
| { | ||
| **response.usage.opentelemetry_attributes(), | ||
| 'gen_ai.response.model': response_model, | ||
| events = self.instrumentation_settings.messages_to_otel_events(messages) |
Collaborator
There was a problem hiding this comment.
These changes shouldn't be necessary (anymore)
Collaborator
|
@fatelei Please merge main, there are some merge conflicts that are preventing the tests and linter to run in CI |
DouweM
requested changes
Sep 5, 2025
DouweM
changed the title
ModelResponse.finish_reason and set provider_response_id while streaming
# Conflicts: # uv.lock
DouweM
changed the title
ModelResponse.finish_reason and set provider_response_id while streamingModelResponse.finish_reason, set provider_response_id while streaming, set both on OTel spans
DouweM
changed the title
ModelResponse.finish_reason, set provider_response_id while streaming, set both on OTel spansModelResponse.finish_reason and set provider_response_id while streaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #886