-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Closed
Labels
Description
Some changes we need to be more in line with the OTel specs:
- Span name should be
invoke_agent {gen_ai.agent.name}instead ofagent run - Attribute
agent_nameshould begen_ai.agent.name. For this one, let's just duplicate the attribute immediately, i.e. set both names to the same value.
- Span name should be
execute_tool {gen_ai.tool.name}instead ofrunning tool -
gen_ai.tool.call.argumentswhere we’ve been usingtool_arguments -
gen_ai.tool.call.resultwhere we’ve been usingtool_response
All these names are already being actively used in queries, changing them would cause breakages, although just copying agent_name is fine. Most users probably don't actually care about these right now. So I think InstrumentationSettings(version=3) should be introduced to allow enabling some or all of these changes, while the default version=2 remains. If making all these changes in a single PR is a pain, then version=3 can apply some subset while the rest is for version=4 or beyond.
The span names are the most important for the sake of improving the display in #2925.
The gen_ai.tool.call.* attributes are not even part of the released spec yet, so not very important.