Add unique run_id to run, run result, and message (request, response) classes
#3366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raphState to these ModelMessages
adtyavrdhn
changed the title
Contributor
Author
|
@DouweM A lot of tests will need to be modified to accommodate run_id in the snapshots. |
DouweM
requested changes
Nov 7, 2025
Collaborator
@adtyavrdhn Yep, we'll need |
…dding_run_id_to_modelmessage
Contributor
Author
|
This ended up being a much bigger diff than what I was expecting |
adtyavrdhn
commented
Nov 8, 2025
DouweM
requested changes
Nov 10, 2025
Collaborator
DouweM
left a comment
DouweM
left a comment
There was a problem hiding this comment.
@adtyavrdhn Nice work Aditya!
…sult, AgentRun + docstring changes
…dding_run_id_to_modelmessage
…dding_run_id_to_modelmessage
DouweM
requested changes
Nov 11, 2025
…dding_run_id_to_modelmessage
…dding_run_id_to_modelmessage
DouweM
changed the title
run_id to run, run resuilt, and message (request, response) classes
DouweM
changed the title
run_id to run, run resuilt, and message (request, response) classesrun_id to run, run result, and message (request, response) classes
DouweM
changed the title
run_id to run, run result, and message (request, response) classesrun_id to run, run result, and message (request, response) classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3171
Adds a UUID run_id at agent start, thread it through GraphAgentState, and assign it to every ModelRequest/ModelResponse as they’re created so all execution paths share one identifier.
Keep run_id optional on message classes for backward compatibility.
Cover the change with tests:
(1) assert captured messages and result.all_messages() all carry the same non-empty run_id and
(2) confirm ModelMessagesTypeAdapter preserves the field through serialization.