-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update docs on multi-modal file URLs being downloaded or sent directly #3492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added example code for file uploads and inline usage with Gemini GLA. - Clarified Google GLA file upload option
|
hey @marmor7 thank you for the PR, I left two comments on the code but wanted to give you some pointers as well Firstly, you created the PR from the github UI, so you can't really review what your changes are gonna look like on the docs
Secondly, your code examples use variables that aren't defined in the example. Generally, it's a good practice to provide examples that run "as is", i.e., the user can copy the example and run it without needing to find out, e.g., where the One thing in the example you provided for passing a file in-line, is you used the variable |
|
thanks @dsfaccini I've made the two code samples complete as requested. in the upload version I've switched to the more clear and concise: and for the inline version: BTW, you've mentioned you added comments in the code, I didn't see them, did you submit your review? |
|
hey @marmor7, thank you for the changes, a couple of notes:
BTW you're right I added the comments but never started the review, sorry for that. I've submitted the review now. |
|
@dsfaccini i fixed all your comments (with the exception of guess_type) and I think it's now good enough to get merged, but CI is failing for some reason, even though all checks that actually ran were successful. |
docs/input.md
Outdated
|
|
||
| - [`GoogleModel`][pydantic_ai.models.google.GoogleModel] on GLA: YouTube video URLs are sent directly in the request to the model. | ||
| ## Example code for Gemini GLA | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still needs updating the title to sth like "Uploaded files"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought you meant the header one line below which now reads "Use uploaded files" as you suggested.
for the header above "Example code for Gemini GLA", it doesn't make sense to change to "Uploaded files" as i'm providing two separate code examples, one for uploaded files and one for inlined files.
Update docs following PR:
#2270
I moved the Google GLA bullet above Google Vertex, because the inlined section that was vertex-specific did not seem inlined in the final doc, so it made the Google GLA bullet feel out of place: