Skip to content

Don't emit AG-UI text message content events with empty text part deltas #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DouweM merged 2 commits into from
Sep 3, 2025
Merged

Don't emit AG-UI text message content events with empty text part deltas #2779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8b60ac
Don't emit AG-UI text message content events with empty text part upd…
celeritatem Sep 3, 2025
5d4342c
Update AG-UI thinking test case to confirm that empty text parts are …
celeritatem Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pydantic_ai_slim/pydantic_ai/ag_ui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,10 +488,11 @@ async def _handle_model_request_event( # noqa: C901
elif isinstance(agent_event, PartDeltaEvent):
delta = agent_event.delta
if isinstance(delta, TextPartDelta):
yield TextMessageContentEvent(
message_id=stream_ctx.message_id,
delta=delta.content_delta,
)
if delta.content_delta: # pragma: no branch
yield TextMessageContentEvent(
message_id=stream_ctx.message_id,
delta=delta.content_delta,
)
elif isinstance(delta, ToolCallPartDelta): # pragma: no branch
assert delta.tool_call_id, '`ToolCallPartDelta.tool_call_id` must be set'
yield ToolCallArgsEvent(
Expand Down
1 change: 1 addition & 0 deletions tests/test_ag_ui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,6 +864,7 @@ async def stream_function(
) -> AsyncIterator[DeltaThinkingCalls | str]:
yield {0: DeltaThinkingPart(content='')}
yield "Let's do some thinking"
yield ''
yield {1: DeltaThinkingPart(content='Thinking ')}
yield {1: DeltaThinkingPart(content='about the weather')}
yield {2: DeltaThinkingPart(content='')}
Expand Down