Respect openai_supports_tool_choice_required model profile setting in OpenAIResponsesModel
#3272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DouweM
requested changes
Oct 28, 2025
DouweM
changed the title
openai_supports_tool_choice_required model profile setting in OpenAIResponsesModel
pamelafox
changed the title
openai_supports_tool_choice_required model profile setting in OpenAIResponsesModelopenai_supports_tool_choice_required model profile setting in OpenAIResponsesModel
Collaborator
|
@pamelafox Thanks Pamela, enabled the auto-merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3270 as suggested by @DouweM in that thread. (Does not yet add a vLLMProvider however.)
This PR adds support for openai_supports_tool_choice_required to the OpenAI Responses API, which was already supported for the OpenAI Chat Completions API.
I added a unit test based off the test that was added for the original openai_supports_tool_choice_required change.