Refine reasoning model identification logic #3331
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current approach will cause an error, saying encrypted content is not allowed. This is due to get-5-chat-latest not being a reasoning model but still being identified as a reasoning model where encrypted content would normally be allowed.
Collaborator
|
@RaymanP02 Looks like we were working on this at the same time :) My PR ensures |
Author
|
@DouweM Ah perfect, missed that part :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current approach will cause an error, saying encrypted content is not allowed. This is due to get-5-chat-latest not being a reasoning model but still being identified as a reasoning model where encrypted content would normally be allowed.
Related to issue #3326