Skip to content

Conversation

@crossk3
Copy link
Contributor

@crossk3 crossk3 commented Nov 6, 2025

Temporal python SDK version 1.18.0 has some issues related to codec servers, namely issues where Search Attributes on Child Workflows caused un-retryable failures (fixed 1.18.1) and cause fields in failures were not being encoded properly (fixed 1.18.2)

Hit these in the wild while bumping pydantic-ai-slim to 1.10.

Copy link
Collaborator

@DouweM DouweM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crossk3 Thanks Keaton! Just one comment

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4,218 additions, 4,209 deletions not shown because the diff is too large. Please use a local Git client to view these changes.

That's a lot more diff then there should be for a small change like this :)

Can you make sure you're on the latest uv, reset uv.lock and then generate it again with uv lock? I'd expect only temporal-related sections to change.

Copy link
Contributor Author

@crossk3 crossk3 Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely. I tried resetting with uv sync --frozen on main but the overall version difference was relatively small (just temporalio and the installed version of pydantic-graph) so I figured it was probably just noise. I'll update uv and see if that changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DouweM Much smaller diff on the latest uv version. Thanks for nudging me to update.

@crossk3 crossk3 force-pushed the kcross-use-newer-temporal branch from 4ab1d12 to e43064c Compare November 6, 2025 17:50
@crossk3 crossk3 requested a review from DouweM November 6, 2025 17:50
@DouweM DouweM changed the title chore(deps): stop using broken temporal 1.18.0 Bump temporal to v1.18.2 as v1.18.0 is broken Nov 6, 2025
@DouweM DouweM changed the title Bump temporal to v1.18.2 as v1.18.0 is broken Bump temporalio to v1.18.2 as v1.18.0 is broken Nov 6, 2025
@DouweM DouweM merged commit 5768447 into pydantic:main Nov 6, 2025
32 checks passed
@crossk3 crossk3 deleted the kcross-use-newer-temporal branch November 6, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants