-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add FileSearchTool with support for OpenAI and Google
#3396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gorkachea
wants to merge
28
commits into
pydantic:main
Choose a base branch
from
gorkachea:add-file-search-tools-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
4376b96
✨ Add support for OpenAI and Gemini File Search Tools
gorkachea 6cec96f
Fix type checking and formatting issues
gorkachea 4c3fe56
Merge branch 'main' into add-file-search-tools-support
gorkachea 3c8decf
docs: Remove runnable markers from FileSearchTool examples
gorkachea 2343679
Skip tests for file_search documentation examples
gorkachea 666a1bb
Add unit tests for FileSearchTool to improve coverage
gorkachea 7365e20
Update FileSearchTool tests with comprehensive mocking
gorkachea 2ee21c9
Add pragma: no cover to FileSearchTool API-dependent code paths
gorkachea deef1ec
Remove problematic FileSearchTool tests that access private members
gorkachea 18b4b86
Fix end-of-file formatting
gorkachea 11654ed
Add pragma: no cover to remaining FileSearchTool helper function
gorkachea 1542f5c
Apply ruff formatting
gorkachea 7d683b7
Add pragma: no cover to FileSearchTool status handling line
gorkachea d8ef07d
Remove incorrect pragma: no cover from anthropic.py line 460
gorkachea 6acbd76
docs: address PR feedback for FileSearchTool documentation
gorkachea 380e25c
clean up FileSearchTool comments
gorkachea c83f125
remove pragma: no cover from FileSearchTool code
gorkachea 8eba82d
use file_search_store_names for Google file search
gorkachea b3a8930
fix OpenAI file search to use queries and results fields
gorkachea 19f32f9
add builtin tool call/return parts for Google file search
gorkachea 00ea1ed
Implement FileSearchDict for Google file search and enhance tests
gorkachea c6ed56c
add unit tests for FileSearchTool parsing logic
gorkachea 9b5bb54
Merge branch 'main' into add-file-search-tools-support
gorkachea c2765ac
upgrade google-genai SDK to v1.49.0 with file_search support
gorkachea 8286cd7
add integration tests for FileSearchTool
gorkachea 3011e05
add VCR decorators to FileSearchTool integration tests
gorkachea bc278e8
fix Google FileSearchTool SDK parameters and add VCR decorators
gorkachea 5f694c9
fix type errors in FileSearchTool integration tests
gorkachea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not vertex AI?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DouweM Logan Kilpatrick responded on Twitter that Gemini File Search API is not yet available on Vertex AI.
https://x.com/OfficialLoganK/status/1986581779927494837
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shun-liang for checking! Correct, it's not available on Vertex AI yet according to Logan's response.