adjustments, allow failure for now

Author: davidhewitt

.github/workflows/ci.yml

@@ -74,6 +74,9 @@ jobs:
 
     runs-on: ubuntu-latest
 
+    # TODO: get test suite stable with free-threaded python
+    continue-on-error: ${{ endsWith(matrix.python-version, 't') }}
+
     steps:
       - uses: actions/checkout@v4
 
@@ -97,15 +100,14 @@ jobs:
         env:
           RUST_BACKTRACE: 1
 
-      - if: endsWith(matrix.python-version, 't')
-        run: uv pip install pytest-run-parallel
-
       - run: uv pip freeze
 
       - run: uv run pytest
         env:
           HYPOTHESIS_PROFILE: slow
           PYTEST_ADDOPTS: ${{ endsWith(matrix.python-version, 't') && '--parallel-threads=2' || '' }}
+          # TODO: add `gil_used = false` to the PyO3 `#[pymodule]` when test suite is ok
+          PYTHON_GIL: ${{ endsWith(matrix.python-version, 't') && '0' || '1' }}
 
   test-os:
     name: test on ${{ matrix.os }}

pyproject.toml

@@ -52,6 +52,7 @@ testing = [
     'pytest-speed',
     'pytest-mock',
     'pytest-pretty',
+    'pytest-run-parallel',
     'pytest-timeout',
     'python-dateutil',
     # numpy doesn't offer prebuilt wheels for all versions and platforms we test in CI e.g. aarch64 musllinux
@@ -108,8 +109,8 @@ filterwarnings = [
     # cases, by not making this an error we can test for this behaviour
     'ignore:(.+)Implicit conversion to integers using __int__ is deprecated',
     # free-threading seems to upset Hypothesis
-    'ignore:The recursion limit will not be reset, since it was changed from another thread or during execution of a test.',
-    'ignore:Do not use the `random` module inside strategies; instead consider  `st.randoms()`, `st.sampled_from()`, etc.  from data=datetimes()',
+    'ignore:(.*)The recursion limit will not be reset, since it was changed from another thread or during execution of a test.(.*)',
+    'ignore:(.*)Do not use the `random` module inside strategies(.*)',
 ]
 timeout = 30
 xfail_strict = true

src/argument_markers.rs

@@ -5,6 +5,7 @@ use pyo3::types::{PyDict, PyTuple};
 
 use crate::tools::safe_repr;
 
+// see https://github.com/PyO3/pyo3/issues/4894 - freelist is currently unsound with GIL disabled
 #[cfg_attr(
     not(Py_GIL_DISABLED),
     pyclass(module = "pydantic_core._pydantic_core", get_all, frozen, freelist = 100)

src/lib.rs

@@ -106,7 +106,7 @@ pub fn build_info() -> String {
     )
 }
 
-#[pymodule(gil_used = false)]
+#[pymodule]
 fn _pydantic_core(py: Python, m: &Bound<'_, PyModule>) -> PyResult<()> {
     m.add("__version__", get_pydantic_core_version())?;
     m.add("build_profile", env!("PROFILE"))?;

tests/validators/test_set.py

@@ -73,6 +73,7 @@ def test_frozenset_no_validators_both(py_and_json: PyAndJson, input_value, expec
         ('abc', Err('Input should be a valid set')),
     ],
 )
+@pytest.mark.thread_unsafe  # generators in parameters not compatible with pytest-run-parallel, https://github.com/Quansight-Labs/pytest-run-parallel/issues/14
 def test_set_ints_python(input_value, expected):
     v = SchemaValidator({'type': 'set', 'items_schema': {'type': 'int'}})
     if isinstance(expected, Err):