use Option<bool> for serialize_by_alias config to be consistent with validation alias/name settings

Author: sydney-runkle

src/serializers/computed_fields.rs

@@ -116,7 +116,7 @@ struct ComputedField {
     serializer: CombinedSerializer,
     alias: String,
     alias_py: Py<PyString>,
-    serialize_by_alias: bool,
+    serialize_by_alias: Option<bool>,
 }
 
 impl ComputedField {
@@ -134,14 +134,13 @@ impl ComputedField {
         let alias_py = schema
             .get_as(intern!(py, "alias"))?
             .unwrap_or_else(|| property_name.clone());
-        let serialize_by_alias = config.get_as(intern!(py, "serialize_by_alias"))?.unwrap_or(false);
         Ok(Self {
             property_name: property_name.extract()?,
             property_name_py: property_name.into(),
             serializer,
             alias: alias_py.extract()?,
             alias_py: alias_py.into(),
-            serialize_by_alias,
+            serialize_by_alias: config.get_as(intern!(py, "serialize_by_alias"))?,
         })
     }
 

src/serializers/extra.rs

@@ -205,8 +205,8 @@ impl<'a> Extra<'a> {
         self.model.and_then(|model| model.get_type().name().ok())
     }
 
-    pub fn serialize_by_alias_or(&self, serialize_by_alias: bool) -> bool {
-        self.by_alias.unwrap_or(serialize_by_alias)
+    pub fn serialize_by_alias_or(&self, serialize_by_alias: Option<bool>) -> bool {
+        self.by_alias.unwrap_or(serialize_by_alias.unwrap_or(false))
     }
 }
 

src/serializers/fields.rs

@@ -29,7 +29,7 @@ pub(super) struct SerField {
     // None serializer means exclude
     pub serializer: Option<CombinedSerializer>,
     pub required: bool,
-    pub serialize_by_alias: bool,
+    pub serialize_by_alias: Option<bool>,
 }
 
 impl_py_gc_traverse!(SerField { serializer });
@@ -41,7 +41,7 @@ impl SerField {
         alias: Option<String>,
         serializer: Option<CombinedSerializer>,
         required: bool,
-        serialize_by_alias: bool,
+        serialize_by_alias: Option<bool>,
     ) -> Self {
         let alias_py = alias.as_ref().map(|alias| PyString::new(py, alias.as_str()).into());
         Self {

src/serializers/type_serializers/dataclass.rs

@@ -37,7 +37,7 @@ impl BuildSerializer for DataclassArgsBuilder {
             _ => FieldsMode::SimpleDict,
         };
 
-        let serialize_by_alias = config.get_as(intern!(py, "serialize_by_alias"))?.unwrap_or(false);
+        let serialize_by_alias = config.get_as(intern!(py, "serialize_by_alias"))?;
 
         for (index, item) in fields_list.iter().enumerate() {
             let field_info = item.downcast::<PyDict>()?;

src/serializers/type_serializers/model.rs

@@ -47,7 +47,7 @@ impl BuildSerializer for ModelFieldsBuilder {
             (_, _) => None,
         };
 
-        let serialize_by_alias = config.get_as(intern!(py, "serialize_by_alias"))?.unwrap_or(false);
+        let serialize_by_alias = config.get_as(intern!(py, "serialize_by_alias"))?;
 
         for (key, value) in fields_dict {
             let key_py = key.downcast_into::<PyString>()?;

src/serializers/type_serializers/typed_dict.rs

@@ -32,7 +32,7 @@ impl BuildSerializer for TypedDictBuilder {
             _ => FieldsMode::SimpleDict,
         };
 
-        let serialize_by_alias = config.get_as(intern!(py, "serialize_by_alias"))?.unwrap_or(false);
+        let serialize_by_alias = config.get_as(intern!(py, "serialize_by_alias"))?;
 
         let fields_dict: Bound<'_, PyDict> = schema.get_as_req(intern!(py, "fields"))?;
         let mut fields: AHashMap<String, SerField> = AHashMap::with_capacity(fields_dict.len());