fix tests + get things working with validate_by_name

Author: sydney-runkle

src/validators/arguments.rs

@@ -8,7 +8,7 @@ use ahash::AHashSet;
 use pyo3::IntoPyObjectExt;
 
 use crate::build_tools::py_schema_err;
-use crate::build_tools::ExtraBehavior;
+use crate::build_tools::{schema_or_config_same, ExtraBehavior};
 use crate::errors::{ErrorTypeDefaults, ValError, ValLineError, ValResult};
 use crate::input::{Arguments, BorrowInput, Input, KeywordArgs, PositionalArgs, ValidationMatch};
 use crate::lookup_key::LookupKey;
@@ -68,7 +68,7 @@ impl BuildValidator for ArgumentsValidator {
     ) -> PyResult<CombinedValidator> {
         let py = schema.py();
 
-        let validate_by_name = config.get_as(intern!(py, "validate_by_name"))?.unwrap_or(false);
+        let validate_by_name = schema_or_config_same(schema, config, intern!(py, "validate_by_name"))?.unwrap_or(false);
 
         let arguments_schema: Bound<'_, PyList> = schema.get_as_req(intern!(py, "arguments_schema"))?;
         let mut parameters: Vec<Parameter> = Vec::with_capacity(arguments_schema.len());

tests/validators/test_typed_dict.py

@@ -396,8 +396,8 @@ def test_alias_allow_pop(py_and_json: PyAndJson):
             'fields': {
                 'field_a': {'validation_alias': 'FieldA', 'type': 'typed-dict-field', 'schema': {'type': 'int'}}
             },
+            'config': {'validate_by_name': True},
         },
-        config=CoreConfig(validate_by_name=True),
     )
     assert v.validate_test({'FieldA': '123'}) == {'field_a': 123}
     assert v.validate_test({'field_a': '123'}) == {'field_a': 123}
@@ -590,8 +590,8 @@ def test_paths_allow_by_name(py_and_json: PyAndJson, input_value):
                     'schema': {'type': 'int'},
                 }
             },
+            'config': {'validate_by_name': True},
         },
-        config=CoreConfig(validate_by_name=True),
     )
     assert v.validate_test(input_value) == {'field_a': 42}
 
@@ -798,8 +798,8 @@ def test_alias_extra_by_name(py_and_json: PyAndJson):
             'fields': {
                 'field_a': {'validation_alias': 'FieldA', 'type': 'typed-dict-field', 'schema': {'type': 'int'}}
             },
+            'config': {'validate_by_name': True},
         },
-        config=CoreConfig(validate_by_name=True),
     )
     assert v.validate_test({'FieldA': 1}) == {'field_a': 1}
     assert v.validate_test({'field_a': 1}) == {'field_a': 1}