Skip to content

Commit fb5cecb

Browse files
committed
adjustments based on PR comments
1 parent 556009d commit fb5cecb

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

src/input/shared.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,6 @@ pub fn fraction_as_int<'py>(
234234
) -> ValResult<EitherInt<'py>> {
235235
let py = fraction.py();
236236

237-
// as_integer_ratio was added in Python 3.8, so this should be fine
238237
let (numerator, denominator) = fraction
239238
.call_method0(intern!(py, "as_integer_ratio"))?
240239
.extract::<(Bound<'_, PyAny>, Bound<'_, PyAny>)>()?;

src/validators/fraction.rs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -84,14 +84,6 @@ impl Validator for FractionValidator {
8484
) -> ValResult<Py<PyAny>> {
8585
let fraction = input.validate_fraction(state.strict_or(self.strict), py)?.unpack(state);
8686

87-
// let mut is_nan: Option<bool> = None;
88-
// let mut is_nan = || -> PyResult<bool> {
89-
// match is_nan {
90-
// Some(is_nan) => Ok(is_nan),
91-
// None => Ok(*is_nan.insert(decimal.call_method0(intern!(py, "is_nan"))?.extract()?)),
92-
// }
93-
// };
94-
9587
if let Some(le) = &self.le {
9688
if !fraction.le(le)? {
9789
return Err(ValError::new(

0 commit comments

Comments
 (0)