Skip to content

Conversation

@sydney-runkle
Copy link
Contributor

@sydney-runkle sydney-runkle commented Oct 11, 2024

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 11, 2024

CodSpeed Performance Report

Merging #1482 will not alter performance

Comparing invalid-fix (475cb3b) with main (bbd4de5)

Summary

✅ 155 untouched benchmarks

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks reasonable, but the PR title seems to describe something completely different?

@sydney-runkle sydney-runkle changed the title Remove InvalidSchema from CoreSchema for typing purposes Add serialization key to InvalidSchema Oct 15, 2024
@sydney-runkle
Copy link
Contributor Author

The patch looks reasonable, but the PR title seems to describe something completely different?

Fixed, thanks.

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@sydney-runkle sydney-runkle merged commit c38a68d into main Oct 15, 2024
28 of 29 checks passed
@sydney-runkle sydney-runkle deleted the invalid-fix branch October 15, 2024 14:49
davidhewitt pushed a commit to pydantic/pydantic that referenced this pull request Oct 20, 2025
davidhewitt pushed a commit to pydantic/pydantic that referenced this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants